[PATCH v1] obexd/pbap: Fix u128_to_string skipping data[4]

[PATCH v1] obexd/pbap: Fix u128_to_string skipping data[4]

[Jinwang Li]

u128_to_string uses data[3] twice causing data[4] to be skipped and
DatabaseIdentifier, PrimaryCounter and SecondaryCounter properties to
be printed with wrong values.

Fixes: 5ee26d43c65c ("obexd/client: Add DatabaseIdentifier property")
Assisted-by: opencode:claude-sonnet-5
Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
---
 obexd/client/pbap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/obexd/client/pbap.c b/obexd/client/pbap.c
index ce5e6cd5d..1970d3357 100644
--- a/obexd/client/pbap.c
+++ b/obexd/client/pbap.c
@@ -1099,7 +1099,7 @@ static int u128_to_string(uint8_t *data, char *str, size_t len)
 	return snprintf(str, len, "%02X%02X%02X%02X%02X%02X%02X%02X"
 					"%02X%02X%02X%02X%02X%02X%02X%02X",
 					data[0], data[1], data[2], data[3],
-					data[3], data[5], data[6], data[7],
+					data[4], data[5], data[6], data[7],
 					data[8], data[9], data[10], data[11],
 					data[12], data[13], data[14], data[15]);
 }
-- 
2.34.1

RE: [v1] obexd/pbap: Fix u128_to_string skipping data[4]

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 858 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1171825/

---Test result---

Test Summary:
CheckPatch                    PASS      0.51 seconds
GitLint                       PASS      0.35 seconds
BuildEll                      PASS      19.55 seconds
BluezMake                     PASS      376.17 seconds
CheckSmatch                   PASS      293.19 seconds
bluezmakeextell               PASS      95.53 seconds
TestFunctional                PASS      1104.66 seconds
IncrementalBuild              PASS      377.54 seconds
ScanBuild                     PASS      1158.87 seconds



https://github.com/bluez/bluez/pull/2568

---
Regards,
Linux Bluetooth

Re: [PATCH v1] obexd/pbap: Fix u128_to_string skipping data[4]

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 23 Sep 2026 11:29:57 +0800 you wrote:
> u128_to_string uses data[3] twice causing data[4] to be skipped and
> DatabaseIdentifier, PrimaryCounter and SecondaryCounter properties to
> be printed with wrong values.
> 
> Fixes: 5ee26d43c65c ("obexd/client: Add DatabaseIdentifier property")
> Assisted-by: opencode:claude-sonnet-5
> Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
> 
> [...]

Here is the summary with links:
  - [v1] obexd/pbap: Fix u128_to_string skipping data[4]
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=8b4a41760638

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html