Linux bluetooth development
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@tieto.com>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 4/6] android/socket: Reserve channel for HSP AG
Date: Fri, 28 Feb 2014 18:06:07 +0100	[thread overview]
Message-ID: <1848977.f8HFz4UXRu@uw000953> (raw)
In-Reply-To: <20140228164459.GA23792@localhost.P-661HNU-F1>

Hi Johan,

On Friday 28 of February 2014 18:44:59 Johan Hedberg wrote:
> Hi Szymon,
> 
> On Fri, Feb 28, 2014, Szymon Janc wrote:
> > ---
> >  android/socket.c | 14 ++++++++++++--
> >  1 file changed, 12 insertions(+), 2 deletions(-)
> > 
> > diff --git a/android/socket.c b/android/socket.c
> > index ee98b54..f6863c8 100644
> > --- a/android/socket.c
> > +++ b/android/socket.c
> > @@ -47,8 +47,9 @@
> >  
> >  #define RFCOMM_CHANNEL_MAX 30
> >  
> > +#define HSP_AG_DEFAULT_CHANNEL	11
> >  #define OPP_DEFAULT_CHANNEL	12
> > -#define HFAG_DEFAULT_CHANNEL	13
> > +#define HFP_AG_DEFAULT_CHANNEL	13
> >  #define PBAP_DEFAULT_CHANNEL	19
> 
> Wasn't our plan to mirror the BlueZ doc/assigned-numbers.txt here? At
> least the OPP and HSP channels don't match up with that.

We followed Bluedroid channels (although for HSP I did check which one is
used:), but we could go with BlueZ assigned-numbers.txt. That would require
fixed channels numbers for MAP, but that shouldn't be a problem.

Will send a patch for that.

-- 
Best regards, 
Szymon Janc

  reply	other threads:[~2014-02-28 17:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28 16:19 [PATCH 1/6] android/ipc: Add command to enable HFP in handsfree HAL Szymon Janc
2014-02-28 16:19 ` [PATCH 2/6] android/handsfree: Add support for enable HFP command Szymon Janc
2014-02-28 16:19 ` [PATCH 3/6] android/hal-handsfree: " Szymon Janc
2014-02-28 16:19 ` [PATCH 4/6] android/socket: Reserve channel for HSP AG Szymon Janc
2014-02-28 16:44   ` Johan Hedberg
2014-02-28 17:06     ` Szymon Janc [this message]
2014-02-28 17:19       ` Marcel Holtmann
2014-02-28 17:45         ` Szymon Janc
2014-02-28 17:54           ` Marcel Holtmann
2014-02-28 16:19 ` [PATCH 5/6] android/handsfree: Add support " Szymon Janc
2014-02-28 16:19 ` [PATCH 6/6] android/handsfree: Allow to connect to HSP or HFP handsfree unit Szymon Janc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1848977.f8HFz4UXRu@uw000953 \
    --to=szymon.janc@tieto.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox