Re: [PATCH 4/6] android/socket: Reserve channel for HSP AG

[Szymon Janc <szymon.janc@tieto.com>]

Hi Marcel,

On Friday 28 of February 2014 09:19:53 Marcel Holtmann wrote:
> Hi Szymon,
> 
> >>> ---
> >>> android/socket.c | 14 ++++++++++++--
> >>> 1 file changed, 12 insertions(+), 2 deletions(-)
> >>> 
> >>> diff --git a/android/socket.c b/android/socket.c
> >>> index ee98b54..f6863c8 100644
> >>> --- a/android/socket.c
> >>> +++ b/android/socket.c
> >>> @@ -47,8 +47,9 @@
> >>> 
> >>> #define RFCOMM_CHANNEL_MAX 30
> >>> 
> >>> +#define HSP_AG_DEFAULT_CHANNEL	11
> >>> #define OPP_DEFAULT_CHANNEL	12
> >>> -#define HFAG_DEFAULT_CHANNEL	13
> >>> +#define HFP_AG_DEFAULT_CHANNEL	13
> >>> #define PBAP_DEFAULT_CHANNEL	19
> >> 
> >> Wasn't our plan to mirror the BlueZ doc/assigned-numbers.txt here? At
> >> least the OPP and HSP channels don't match up with that.
> > 
> > We followed Bluedroid channels (although for HSP I did check which one is
> > used:), but we could go with BlueZ assigned-numbers.txt. That would require
> > fixed channels numbers for MAP, but that shouldn't be a problem.
> 
> lets go with the Bluedroid ones, but make sure we document it somewhere which ones are used for what. I do not want to have to dig that out of the code.

With Bluedroid there is bit awkward situation. Only PBAP and OPP channels are
explicitly reserved.

There is also comment that channel 1 is reserved for HFP AG but... when HFP AG
record is registered it skips channel 1 (due to it being already 'reserved' :)).

This results in HSP AG using channel 2, and HFP using channel 3 when both are
enabled. If one would disable HSP, then HFP would have channel 2. So those are
kind of dynamic :)

Opinions?:)

-- 
Best regards, 
Szymon Janc