Re: [Bluez-devel] Regarding a2recv

["Henryk Plötz" <henryk@ploetzli.ch>]

[-- Attachment #1: Type: text/plain, Size: 2425 bytes --]

Moin,

Am Sun, 8 May 2005 13:50:39 +0100 (BST) schrieb Mayank Batra:

> I believe that should have been a problem because
> interchanding packet_type and message_type does make a
> lot of difference to the avdtp packet.

Yes, it does.

I now completely restructured the a2recv code into something that more
closely resembles a socket server application. Basically it is now a
giant endless loop that is blocking in select() on the serverfd and
optionally the cmdfd and streamfd (should they be open) and as soon as
there is data to read or a connection to accept I am reading it.

There is also an internal state like that from the AVDTP spec and I'm
treating incoming packets based on that state. This will allow any
sequence of AVDTP_DISCOVER, AVDTP_GET_CAPABILITIES, AVDTP_OPEN, etc.
commands to occur and also makes it possible to have the server handle
more than one connection during its lifetime (only one at a time, of
course).

The code is currently completely lacking any error handling, and simply
ignores the offending packet (or exits), so that should be added. I also
don't like the structs used for the avdtp signalling packets, I think
there should only be one struct that includes a struct avdtp_header and
a union with all the other optional signalling contents. Then there
would have to be specialised read()/write() functions which figure out
(based on the header) how long the packet actually is and automatically
send/receive that many bytes. However, that would also require
modification of a2play so I thought I'd ask first.

That would make it easier to send rejection messages (which may differ
from the acceptance message in length) and do proper error handling.

> Why doesn't the streaming start?

If I only knew ...
The current code shows me that the stream connection is correctly
established and the start streaming response is sent. Then after some
seconds I get a read error on the command fd with error message
"Connection timed out". 

Again, please check that I didn't break your devices. I can only test
with a2play. There might also still be some flaws in the state handling
since this is slightly more complex than the original straight linear
design.

-- 
Henryk Plötz
Grüße aus Berlin
~~~~~~~ Un-CDs, nein danke! http://www.heise.de/ct/cd-register/ ~~~~~~~
~ Help Microsoft fight software piracy: Give Linux to a friend today! ~

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]