Re: Re: Re: Re: Fwd: Fwd: [PATCH 1/1] shared/gatt-client: Fix the "Find Information req" error

Re: Re: Re: Re: Fwd: Fwd: [PATCH 1/1] shared/gatt-client: Fix the "Find Information req" error

[Nagaraj D R]

SGVsbG8gTHVpeiwNCg0KPk9uIFRodSwgSnVuIDExLCAyMDE1IGF0IDE6MjMgUE0sIE5hZ2FyYWog
RCBSIHdyb3RlOg0KPj4gKytjb3JyZWN0aW9uDQo+PiBEZXNjcmlwdG9ycyBhcmUgc2VhcmNoZWQg
YmV0d2VlbiBDaGFyYWN0ZXJpc3RpYyB2YWx1ZSBkZWNsYXJhdGlvbiBhbmQgY2hhcmFjdGVyaXN0
aWMgZGVmaW5pdGlvbiBlbmQgaGFuZGxlDQoNCj5ObyBUb3AgcG9zdGluZyBvbiB0aGlzIG1haWxp
bmcgbGlzdCBwbGVhc2UuDQo+DQo+PiBIZWxsbyBMdWl6LA0KPj4gVGhlIHByb2JsZW0gdGhhdCBJ
IHdhcyB0cnlpbmcgdG8gYWRkcmVzcyBpcyBmb3IgdGhlIGNoYXJhY3RlcmlzdGljIGF0dHJpYnV0
ZSBhdCAwWGZmZmUgYW5kIGNoYXJhY3RlcmlzdGljIHZhbHVlIGRlY2xhcmF0aW9uIGF0IG94ZmZm
Zi4NCj4+IFRoaXMgaXMgYSB2YWxpZCBzY2VuYXJpby4gQ2hhcmFjdGVyaXN0aWMgbmVlZCB0byBo
YXZlIGEgY2hhcmFjdGVyaXN0aWMgdmFsdWUgZGVjbGFyYXRpb24gYnV0IG5lZWQgbm90IGhhdmUg
Y2hhcmFjdGVyaXN0aWMgZGVzY3JpcHRvcnMuDQo+Pg0KPj4gU2luY2UgcHJlc2VudCBkZXNpZ24g
c2VhcmNoIHRoZSBkZXNjcmlwdG9ycyBiL3cgdGhlIGNoYXJhY3RlcmlzdGljIHZhbHVlIGRlY2xh
cmF0aW9uIGFuZCBzZXJ2aWNlIGVuZCBoYW5kbGUsDQo+PiBpZiBzZXJ2aWNlIGVuZCBoYW5kbGUg
YW5kIGNoYXJhY3RlcmlzdGljIHZhbHVlIGRlY2xhcmF0aW9uIGVuZCBoYW5kbGUgYXJlIHNhbWUg
KGkuZSAweGZmZmYgaW4gYSBwYXJ0aWN1bGFyIGNhc2UpDQo+PiB0aGVuIGRlc2NyaXB0b3Igc2Vh
cmNoIGhhbmRsZSB3aWxsIGJlIGluaXRpYWxpemVkIHRvIDBYMDAwIChpLmUgYnkgaW5jcmVtZW50
aW5nIGNoYXJhY3RlcmlzdGljIHZhbHVlIGhhbmRsZSAoMHhmZmZmKSApDQo+PiAweDAwMDAgaGFu
ZGxlIGlzIHJlc2VydmVkIGhhbmRsZSArIGludGVudGlvbiBvZiBzZWFyY2hpbmcgZGVzY3JpcHRv
ciB3aWxsIG5vdCBiZSBhY2hpZXZlZC4NCg0KPlNvdW5kIGxpa2UgYSBkaWZmZXJlbnQgcHJvYmxl
bSB0aGFuIEkgdGhvdWdodCwgYW55d2F5IGl0IGlzIHZhbGlkIHNvDQo+Y291bGQgeW91IHBsZWFz
ZSBhZGQgdGhpcyBleHBsYW5hdGlvbiB0byB0aGUgcGF0Y2ggZGVzY3JpcHRpb24gYW5kDQo+cGVy
aGFwcyBhIGNvbW1lbnQgdG8gdGhlIGNvZGUgc28gd2UgaGF2ZSBpdCBjcnlzdGFsIGNsZWFyIHdo
eSBpdCBpcw0KPm5lY2Vzc2FyeS4NCg0KSSBoYXZlIHJhaXNlZCB2MiB3aXRoIHRoZSBjaGFuZ2Vz
IHlvdSBzdWdnZXN0ZWQsIHBsZWFzZSBjaGVjayBpdC4NCg0KUmVnYXJkcw0KTmFnYXJhaiBEIFI=

Re: Re: Re: Re: Fwd: Fwd: [PATCH 1/1] shared/gatt-client: Fix the "Find Information req" error

[Luiz Augusto von Dentz]

Hi Nagaraj,

On Mon, Jun 15, 2015 at 11:55 AM, Nagaraj D R <nagaraj.dr@samsung.com> wrote:
> Hello Luiz,
>
>>On Thu, Jun 11, 2015 at 1:23 PM, Nagaraj D R wrote:
>>> ++correction
>>> Descriptors are searched between Characteristic value declaration and characteristic definition end handle
>
>>No Top posting on this mailing list please.
>>
>>> Hello Luiz,
>>> The problem that I was trying to address is for the characteristic attribute at 0Xfffe and characteristic value declaration at oxffff.
>>> This is a valid scenario. Characteristic need to have a characteristic value declaration but need not have characteristic descriptors.
>>>
>>> Since present design search the descriptors b/w the characteristic value declaration and service end handle,
>>> if service end handle and characteristic value declaration end handle are same (i.e 0xffff in a particular case)
>>> then descriptor search handle will be initialized to 0X000 (i.e by incrementing characteristic value handle (0xffff) )
>>> 0x0000 handle is reserved handle + intention of searching descriptor will not be achieved.
>
>>Sound like a different problem than I thought, anyway it is valid so
>>could you please add this explanation to the patch description and
>>perhaps a comment to the code so we have it crystal clear why it is
>>necessary.
>
> I have raised v2 with the changes you suggested, please check it.

Pushed, thanks.


-- 
Luiz Augusto von Dentz