From: Siarhei Siamashka <siarhei.siamashka@nokia.com>
To: "ext Christian Hoene" <hoene@uni-tuebingen.de>
Cc: "'Luiz Augusto von Dentz'" <luiz.dentz@gmail.com>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] SBC Encoder program
Date: Mon, 5 Jan 2009 16:48:48 +0200 [thread overview]
Message-ID: <200901051648.48096.siarhei.siamashka@nokia.com> (raw)
In-Reply-To: <002801c96f43$dd2e70b0$978b5210$@de>
On Monday 05 January 2009 16:42:39 ext Christian Hoene wrote:
> > Just the codesize is 16 bit, right? So I guess the following changes
> > are not really necessary:
> >
> >
> > + uint16_t subbands, channels, blocks;
>
> No, but then we have to change the last line of the function to
> return ((uint16_t)subbands) * blocks * channels * 2;
Not quite so. There is such thing as "integer promotion" defined in C
standard. And integer type is guaranteed to be at least 16 bit. But I
agree that explicitly having uint16_t is much more likely not to raise
any doubts about its correctness :)
--
Best regards,
Siarhei Siamashka
next prev parent reply other threads:[~2009-01-05 14:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200812301246.25781.siarhei.siamashka@nokia.com>
2009-01-01 14:24 ` SBC encoder conformance test for version 4.25 passed! Christian Hoene
2009-01-05 8:27 ` Siarhei Siamashka
2009-01-05 11:43 ` [PATCH] SBC Encoder program Christian Hoene
2009-01-05 12:22 ` Luiz Augusto von Dentz
2009-01-05 12:28 ` Christian Hoene
2009-01-05 13:13 ` Luiz Augusto von Dentz
2009-01-05 14:42 ` Christian Hoene
2009-01-05 14:48 ` Siarhei Siamashka [this message]
2009-01-05 13:22 ` Siarhei Siamashka
2009-01-05 14:42 ` Christian Hoene
2009-01-05 15:18 ` Siarhei Siamashka
2009-01-05 15:24 ` Siarhei Siamashka
2009-01-05 15:33 ` Christian Hoene
2009-01-05 17:39 ` Siarhei Siamashka
2009-01-05 19:45 ` Marcin Tolysz
2009-01-05 21:11 ` David Sainty
2009-01-05 20:36 ` Marcin Tolysz
2009-01-06 2:43 ` Marcel Holtmann
2009-01-05 12:53 ` SBC encoder conformance test for version 4.25 passed! Luiz Augusto von Dentz
2009-07-15 14:49 ` Is it possible that user change a stream path between Speaker and Bluetooth like normal phone? Chan-Yeol Park
2009-07-15 15:27 ` Bastien Nocera
2009-01-05 14:55 ` SBC encoder conformance test for version 4.25 passed! Christian Hoene
2009-01-05 15:32 ` Siarhei Siamashka
2009-01-06 0:40 ` Nick Pelly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901051648.48096.siarhei.siamashka@nokia.com \
--to=siarhei.siamashka@nokia.com \
--cc=hoene@uni-tuebingen.de \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox