From: Siarhei Siamashka <siarhei.siamashka@nokia.com>
To: "ext Christian Hoene" <hoene@uni-tuebingen.de>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: SBC encoder conformance test for version 4.25 passed!
Date: Mon, 5 Jan 2009 17:32:59 +0200 [thread overview]
Message-ID: <200901051732.59929.siarhei.siamashka@nokia.com> (raw)
In-Reply-To: <002901c96f45$a7bbf770$f733e650$@de>
On Monday 05 January 2009 16:55:27 ext Christian Hoene wrote:
> > > Good news! All tests passed!
> > > http://net.cs.uni-tuebingen.de/html/nexgenvoip/
> >
> > Thank you very much. Sorry for the delay with reply too.
> >
> > I wonder if we need to do something about test 08?
>
> Done.
>
> > Also could you try running a special test of version 4.25 with
> > SBC_HIGH_PRECISION enabled? The point is that it uses the best
> > possible precision for the analysis filter and minimizes effects of
> > rounding errors (I would estimate that the precision should be even
> > better than single precision floating point). Having the test run with
>
> this
>
> > precision settings can expose some of the other minor bugs in the code
> > (if they exist), which can now be hidden under the slight precision loss
> > because of using 16-bit fixed point calculations.
>
> I have uploaded the results to
> http://net.cs.uni-tuebingen.de/html/nexgenvoip/4.25_high_precision
>
> The encoding results did not change.
Great, it means that sbc encoder is mostly bug free (at least none of them
shows up on this test set with all the available bugfixes applied).
Now a good improvement would be to tweak the default 16-bit version of
analysis filter to improve its precision. It is a lot faster than the high
precision variant and already provides sufficient quality :)
--
Best regards,
Siarhei Siamashka
next prev parent reply other threads:[~2009-01-05 15:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200812301246.25781.siarhei.siamashka@nokia.com>
2009-01-01 14:24 ` SBC encoder conformance test for version 4.25 passed! Christian Hoene
2009-01-05 8:27 ` Siarhei Siamashka
2009-01-05 11:43 ` [PATCH] SBC Encoder program Christian Hoene
2009-01-05 12:22 ` Luiz Augusto von Dentz
2009-01-05 12:28 ` Christian Hoene
2009-01-05 13:13 ` Luiz Augusto von Dentz
2009-01-05 14:42 ` Christian Hoene
2009-01-05 14:48 ` Siarhei Siamashka
2009-01-05 13:22 ` Siarhei Siamashka
2009-01-05 14:42 ` Christian Hoene
2009-01-05 15:18 ` Siarhei Siamashka
2009-01-05 15:24 ` Siarhei Siamashka
2009-01-05 15:33 ` Christian Hoene
2009-01-05 17:39 ` Siarhei Siamashka
2009-01-05 19:45 ` Marcin Tolysz
2009-01-05 21:11 ` David Sainty
2009-01-05 20:36 ` Marcin Tolysz
2009-01-06 2:43 ` Marcel Holtmann
2009-01-05 12:53 ` SBC encoder conformance test for version 4.25 passed! Luiz Augusto von Dentz
2009-07-15 14:49 ` Is it possible that user change a stream path between Speaker and Bluetooth like normal phone? Chan-Yeol Park
2009-07-15 15:27 ` Bastien Nocera
2009-01-05 14:55 ` SBC encoder conformance test for version 4.25 passed! Christian Hoene
2009-01-05 15:32 ` Siarhei Siamashka [this message]
2009-01-06 0:40 ` Nick Pelly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901051732.59929.siarhei.siamashka@nokia.com \
--to=siarhei.siamashka@nokia.com \
--cc=hoene@uni-tuebingen.de \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox