* [PATCH]btusb:Prevent illtimed autosuspend
@ 2009-12-16 18:23 Oliver Neukum
2009-12-16 18:26 ` Matthew Garrett
0 siblings, 1 reply; 5+ messages in thread
From: Oliver Neukum @ 2009-12-16 18:23 UTC (permalink / raw)
To: Marcel Holtmann, linux-usb, linux-bluetooth, Matthew Garrett
commit 0b72b0a05c1d950e4f35520926cc36bc01fb998a
Author: Oliver Neukum <oliver@neukum.org>
Date: Mon Dec 14 22:09:49 2009 +0100
btusb:Prevent illtimed autosuspend
The device must be marked busy as it recieves data.
Signed-off-by: Oliver Neukum <oliver@neukum.org>
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 4d29059..a699f09 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -307,6 +307,7 @@ static void btusb_bulk_complete(struct urb *urb)
return;
usb_anchor_urb(urb, &data->bulk_anchor);
+ usb_mark_last_busy(data->udev);
err = usb_submit_urb(urb, GFP_ATOMIC);
if (err < 0) {
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH]btusb:Prevent illtimed autosuspend
2009-12-16 18:23 [PATCH]btusb:Prevent illtimed autosuspend Oliver Neukum
@ 2009-12-16 18:26 ` Matthew Garrett
2009-12-16 23:37 ` Marcel Holtmann
0 siblings, 1 reply; 5+ messages in thread
From: Matthew Garrett @ 2009-12-16 18:26 UTC (permalink / raw)
To: Oliver Neukum; +Cc: Marcel Holtmann, linux-usb, linux-bluetooth
On Wed, Dec 16, 2009 at 07:23:43PM +0100, Oliver Neukum wrote:
> commit 0b72b0a05c1d950e4f35520926cc36bc01fb998a
> Author: Oliver Neukum <oliver@neukum.org>
> Date: Mon Dec 14 22:09:49 2009 +0100
>
> btusb:Prevent illtimed autosuspend
>
> The device must be marked busy as it recieves data.
>
> Signed-off-by: Oliver Neukum <oliver@neukum.org>
Tested-by: Matthew Garrett <mjg@redhat.com>
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH]btusb:Prevent illtimed autosuspend
2009-12-16 18:26 ` Matthew Garrett
@ 2009-12-16 23:37 ` Marcel Holtmann
2009-12-16 23:54 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Marcel Holtmann @ 2009-12-16 23:37 UTC (permalink / raw)
To: Matthew Garrett; +Cc: Oliver Neukum, linux-usb, linux-bluetooth
Hi Oliver and Matthew,
> > commit 0b72b0a05c1d950e4f35520926cc36bc01fb998a
> > Author: Oliver Neukum <oliver@neukum.org>
> > Date: Mon Dec 14 22:09:49 2009 +0100
> >
> > btusb:Prevent illtimed autosuspend
> >
> > The device must be marked busy as it recieves data.
> >
> > Signed-off-by: Oliver Neukum <oliver@neukum.org>
>
> Tested-by: Matthew Garrett <mjg@redhat.com>
thanks for figuring this out. I will queue this patch up along with the
other changes and send them to Dave this week.
Regards
Marcel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH]btusb:Prevent illtimed autosuspend
2009-12-16 23:37 ` Marcel Holtmann
@ 2009-12-16 23:54 ` Greg KH
2009-12-17 8:31 ` Oliver Neukum
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2009-12-16 23:54 UTC (permalink / raw)
To: Marcel Holtmann
Cc: Matthew Garrett, Oliver Neukum, linux-usb, linux-bluetooth
On Wed, Dec 16, 2009 at 03:37:57PM -0800, Marcel Holtmann wrote:
> Hi Oliver and Matthew,
>
> > > commit 0b72b0a05c1d950e4f35520926cc36bc01fb998a
> > > Author: Oliver Neukum <oliver@neukum.org>
> > > Date: Mon Dec 14 22:09:49 2009 +0100
> > >
> > > btusb:Prevent illtimed autosuspend
> > >
> > > The device must be marked busy as it recieves data.
> > >
> > > Signed-off-by: Oliver Neukum <oliver@neukum.org>
> >
> > Tested-by: Matthew Garrett <mjg@redhat.com>
>
> thanks for figuring this out. I will queue this patch up along with the
> other changes and send them to Dave this week.
This also might be a -stable patch, right? Care to mark it as such?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH]btusb:Prevent illtimed autosuspend
2009-12-16 23:54 ` Greg KH
@ 2009-12-17 8:31 ` Oliver Neukum
0 siblings, 0 replies; 5+ messages in thread
From: Oliver Neukum @ 2009-12-17 8:31 UTC (permalink / raw)
To: Greg KH; +Cc: Marcel Holtmann, Matthew Garrett, linux-usb, linux-bluetooth
Am Donnerstag, 17. Dezember 2009 00:54:50 schrieb Greg KH:
> On Wed, Dec 16, 2009 at 03:37:57PM -0800, Marcel Holtmann wrote:
> > Hi Oliver and Matthew,
> >
> > > > commit 0b72b0a05c1d950e4f35520926cc36bc01fb998a
> > > > Author: Oliver Neukum <oliver@neukum.org>
> > > > Date: Mon Dec 14 22:09:49 2009 +0100
> > > >
> > > > btusb:Prevent illtimed autosuspend
> > > >
> > > > The device must be marked busy as it recieves data.
> > > >
> > > > Signed-off-by: Oliver Neukum <oliver@neukum.org>
> > >
> > > Tested-by: Matthew Garrett <mjg@redhat.com>
> >
> > thanks for figuring this out. I will queue this patch up along with the
> > other changes and send them to Dave this week.
>
> This also might be a -stable patch, right? Care to mark it as such?
Oh, you are right. Sorry, yes, this should go into 2.6.32 stable,
but nothing earlier. I forgot when btusb autosuspend went in.
Sorry
Oliver
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-12-17 8:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-16 18:23 [PATCH]btusb:Prevent illtimed autosuspend Oliver Neukum
2009-12-16 18:26 ` Matthew Garrett
2009-12-16 23:37 ` Marcel Holtmann
2009-12-16 23:54 ` Greg KH
2009-12-17 8:31 ` Oliver Neukum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox