From: Johan Hedberg <johan.hedberg@gmail.com>
To: "Gustavo F. Padovan" <gustavo@padovan.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] Show F-bit instead of Retransmission Disable
Date: Mon, 12 Jul 2010 14:04:26 -0300 [thread overview]
Message-ID: <20100712170426.GA16225@jh-x301> (raw)
In-Reply-To: <1278953750-18646-1-git-send-email-gustavo@padovan.org>
Hi Gustavo,
On Mon, Jul 12, 2010, Gustavo F. Padovan wrote:
> "F-bit" make more sense for the Enhanced Retranstransmission mode.
> ---
> parser/l2cap.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/parser/l2cap.c b/parser/l2cap.c
> index ad3b7ff..174cd3a 100644
> --- a/parser/l2cap.c
> +++ b/parser/l2cap.c
> @@ -847,7 +847,7 @@ static void l2cap_parse(int level, struct frame *frm)
> }
> printf(" ReqSeq %d", (ctrl & 0x3f00) >> 8);
> if (ctrl & 0x80)
> - printf(" Retransmission Disable");
> + printf(" F-bit");
> printf("\n");
> }
> }
The patch is now upstream. Thanks.
Johan
prev parent reply other threads:[~2010-07-12 17:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 16:55 [PATCH 1/2] Show F-bit instead of Retransmission Disable Gustavo F. Padovan
2010-07-12 16:55 ` [PATCH 2/2] Show P-bit in the l2cap parser Gustavo F. Padovan
2010-07-12 17:04 ` Johan Hedberg
2010-07-12 17:04 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100712170426.GA16225@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox