* [PATCH 1/2] Show F-bit instead of Retransmission Disable
@ 2010-07-12 16:55 Gustavo F. Padovan
2010-07-12 16:55 ` [PATCH 2/2] Show P-bit in the l2cap parser Gustavo F. Padovan
2010-07-12 17:04 ` [PATCH 1/2] Show F-bit instead of Retransmission Disable Johan Hedberg
0 siblings, 2 replies; 4+ messages in thread
From: Gustavo F. Padovan @ 2010-07-12 16:55 UTC (permalink / raw)
To: linux-bluetooth
"F-bit" make more sense for the Enhanced Retranstransmission mode.
---
parser/l2cap.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/parser/l2cap.c b/parser/l2cap.c
index ad3b7ff..174cd3a 100644
--- a/parser/l2cap.c
+++ b/parser/l2cap.c
@@ -847,7 +847,7 @@ static void l2cap_parse(int level, struct frame *frm)
}
printf(" ReqSeq %d", (ctrl & 0x3f00) >> 8);
if (ctrl & 0x80)
- printf(" Retransmission Disable");
+ printf(" F-bit");
printf("\n");
}
}
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] Show P-bit in the l2cap parser
2010-07-12 16:55 [PATCH 1/2] Show F-bit instead of Retransmission Disable Gustavo F. Padovan
@ 2010-07-12 16:55 ` Gustavo F. Padovan
2010-07-12 17:04 ` Johan Hedberg
2010-07-12 17:04 ` [PATCH 1/2] Show F-bit instead of Retransmission Disable Johan Hedberg
1 sibling, 1 reply; 4+ messages in thread
From: Gustavo F. Padovan @ 2010-07-12 16:55 UTC (permalink / raw)
To: linux-bluetooth
---
parser/l2cap.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/parser/l2cap.c b/parser/l2cap.c
index 174cd3a..ee869dc 100644
--- a/parser/l2cap.c
+++ b/parser/l2cap.c
@@ -848,6 +848,8 @@ static void l2cap_parse(int level, struct frame *frm)
printf(" ReqSeq %d", (ctrl & 0x3f00) >> 8);
if (ctrl & 0x80)
printf(" F-bit");
+ if (ctrl & 0x10)
+ printf(" P-bit");
printf("\n");
}
}
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] Show P-bit in the l2cap parser
2010-07-12 16:55 ` [PATCH 2/2] Show P-bit in the l2cap parser Gustavo F. Padovan
@ 2010-07-12 17:04 ` Johan Hedberg
0 siblings, 0 replies; 4+ messages in thread
From: Johan Hedberg @ 2010-07-12 17:04 UTC (permalink / raw)
To: Gustavo F. Padovan; +Cc: linux-bluetooth
Hi Gustavo,
On Mon, Jul 12, 2010, Gustavo F. Padovan wrote:
> ---
> parser/l2cap.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/parser/l2cap.c b/parser/l2cap.c
> index 174cd3a..ee869dc 100644
> --- a/parser/l2cap.c
> +++ b/parser/l2cap.c
> @@ -848,6 +848,8 @@ static void l2cap_parse(int level, struct frame *frm)
> printf(" ReqSeq %d", (ctrl & 0x3f00) >> 8);
> if (ctrl & 0x80)
> printf(" F-bit");
> + if (ctrl & 0x10)
> + printf(" P-bit");
> printf("\n");
> }
> }
This one is upstream now too. Thanks.
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] Show F-bit instead of Retransmission Disable
2010-07-12 16:55 [PATCH 1/2] Show F-bit instead of Retransmission Disable Gustavo F. Padovan
2010-07-12 16:55 ` [PATCH 2/2] Show P-bit in the l2cap parser Gustavo F. Padovan
@ 2010-07-12 17:04 ` Johan Hedberg
1 sibling, 0 replies; 4+ messages in thread
From: Johan Hedberg @ 2010-07-12 17:04 UTC (permalink / raw)
To: Gustavo F. Padovan; +Cc: linux-bluetooth
Hi Gustavo,
On Mon, Jul 12, 2010, Gustavo F. Padovan wrote:
> "F-bit" make more sense for the Enhanced Retranstransmission mode.
> ---
> parser/l2cap.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/parser/l2cap.c b/parser/l2cap.c
> index ad3b7ff..174cd3a 100644
> --- a/parser/l2cap.c
> +++ b/parser/l2cap.c
> @@ -847,7 +847,7 @@ static void l2cap_parse(int level, struct frame *frm)
> }
> printf(" ReqSeq %d", (ctrl & 0x3f00) >> 8);
> if (ctrl & 0x80)
> - printf(" Retransmission Disable");
> + printf(" F-bit");
> printf("\n");
> }
> }
The patch is now upstream. Thanks.
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-07-12 17:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-12 16:55 [PATCH 1/2] Show F-bit instead of Retransmission Disable Gustavo F. Padovan
2010-07-12 16:55 ` [PATCH 2/2] Show P-bit in the l2cap parser Gustavo F. Padovan
2010-07-12 17:04 ` Johan Hedberg
2010-07-12 17:04 ` [PATCH 1/2] Show F-bit instead of Retransmission Disable Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox