Linux bluetooth development
 help / color / mirror / Atom feed
* [PATCH] Use enum from vcard.h for phone types
@ 2010-08-12  7:49 Radoslaw Jablonski
  2010-08-12 11:13 ` Johan Hedberg
  0 siblings, 1 reply; 2+ messages in thread
From: Radoslaw Jablonski @ 2010-08-12  7:49 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Radoslaw Jablonski

Removed redundant declarations for phone types. Now using values from
phonebook_number_type declared in vcard.h.
---
 plugins/phonebook-tracker.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/plugins/phonebook-tracker.c b/plugins/phonebook-tracker.c
index 9cd82e7..8300fc7 100644
--- a/plugins/phonebook-tracker.c
+++ b/plugins/phonebook-tracker.c
@@ -44,8 +44,6 @@
 
 #define TRACKER_DEFAULT_CONTACT_ME "http://www.semanticdesktop.org/ontologies/2007/03/22/nco#default-contact-me"
 #define CONTACTS_ID_COL 19
-#define PHONE_ID_HOME 0
-#define PHONE_ID_WORK 3
 
 #define CONTACTS_QUERY_ALL						\
 	"SELECT nco:phoneNumber(?h) nco:fullname(?c) "			\
@@ -697,8 +695,8 @@ add_entry:
 
 add_numbers:
 	/* Adding phone numbers to contact struct */
-	add_phone_number(contact, reply[0], PHONE_ID_HOME);
-	add_phone_number(contact, reply[8], PHONE_ID_WORK);
+	add_phone_number(contact, reply[0], TEL_TYPE_HOME);
+	add_phone_number(contact, reply[8], TEL_TYPE_WORK);
 
 	DBG("contact %p", contact);
 
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Use enum from vcard.h for phone types
  2010-08-12  7:49 [PATCH] Use enum from vcard.h for phone types Radoslaw Jablonski
@ 2010-08-12 11:13 ` Johan Hedberg
  0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2010-08-12 11:13 UTC (permalink / raw)
  To: Radoslaw Jablonski; +Cc: linux-bluetooth

Hi Radek,

On Thu, Aug 12, 2010, Radoslaw Jablonski wrote:
> Removed redundant declarations for phone types. Now using values from
> phonebook_number_type declared in vcard.h.
> ---
>  plugins/phonebook-tracker.c |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)

The patch has been applied and pushed upstream. Thanks.

Johan

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-08-12 11:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-12  7:49 [PATCH] Use enum from vcard.h for phone types Radoslaw Jablonski
2010-08-12 11:13 ` Johan Hedberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox