* [PATCH] Fix unnecessary checking for empty phones list
@ 2010-08-13 6:35 Radoslaw Jablonski
2010-08-13 12:15 ` Johan Hedberg
0 siblings, 1 reply; 2+ messages in thread
From: Radoslaw Jablonski @ 2010-08-13 6:35 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Radoslaw Jablonski
Removed not needed anymore checking for empty list of phone numbers.
---
plugins/vcard.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/plugins/vcard.c b/plugins/vcard.c
index 9beb62a..80f8265 100644
--- a/plugins/vcard.c
+++ b/plugins/vcard.c
@@ -295,11 +295,6 @@ static void vcard_printf_end(GString *vcards)
void phonebook_add_contact(GString *vcards, struct phonebook_contact *contact,
uint64_t filter, uint8_t format)
{
- /* There's really nothing to do */
- if ((contact->numbers == NULL && (contact->fullname == NULL ||
- contact->fullname[0] == '\0')))
- return;
-
if (format == FORMAT_VCARD30)
filter |= (FILTER_VERSION | FILTER_FN | FILTER_N | FILTER_TEL);
else if (format == FORMAT_VCARD21)
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix unnecessary checking for empty phones list
2010-08-13 6:35 [PATCH] Fix unnecessary checking for empty phones list Radoslaw Jablonski
@ 2010-08-13 12:15 ` Johan Hedberg
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2010-08-13 12:15 UTC (permalink / raw)
To: Radoslaw Jablonski; +Cc: linux-bluetooth
Hi Radek,
On Fri, Aug 13, 2010, Radoslaw Jablonski wrote:
> Removed not needed anymore checking for empty list of phone numbers.
> ---
> plugins/vcard.c | 5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
This patch is now upstream. Thanks.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-13 12:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-13 6:35 [PATCH] Fix unnecessary checking for empty phones list Radoslaw Jablonski
2010-08-13 12:15 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox