* [PATCH] Fix closing stream of locked sep when reconfiguring
@ 2010-09-08 15:13 Luiz Augusto von Dentz
2010-09-08 16:48 ` Johan Hedberg
0 siblings, 1 reply; 2+ messages in thread
From: Luiz Augusto von Dentz @ 2010-09-08 15:13 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.dentz-von@nokia.com>
Stream should only be closed if sep is unlocked otherwise there is a
possibility that sep reconfiguration is triggered although the sep is in
use by the user application.
---
audio/a2dp.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/audio/a2dp.c b/audio/a2dp.c
index b062aed..ef0df17 100644
--- a/audio/a2dp.c
+++ b/audio/a2dp.c
@@ -1393,6 +1393,8 @@ unsigned int a2dp_config(struct avdtp *session, struct a2dp_sep *sep,
}
if (l != NULL) {
+ if (a2dp_sep_get_lock(tmp))
+ goto failed;
setup->reconfigure = TRUE;
if (avdtp_close(session, tmp->stream, FALSE) < 0) {
error("avdtp_close failed");
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Fix closing stream of locked sep when reconfiguring
2010-09-08 15:13 [PATCH] Fix closing stream of locked sep when reconfiguring Luiz Augusto von Dentz
@ 2010-09-08 16:48 ` Johan Hedberg
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2010-09-08 16:48 UTC (permalink / raw)
To: Luiz Augusto von Dentz; +Cc: linux-bluetooth
Hi Luiz,
On Wed, Sep 08, 2010, Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <luiz.dentz-von@nokia.com>
>
> Stream should only be closed if sep is unlocked otherwise there is a
> possibility that sep reconfiguration is triggered although the sep is in
> use by the user application.
> ---
> audio/a2dp.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/audio/a2dp.c b/audio/a2dp.c
> index b062aed..ef0df17 100644
> --- a/audio/a2dp.c
> +++ b/audio/a2dp.c
> @@ -1393,6 +1393,8 @@ unsigned int a2dp_config(struct avdtp *session, struct a2dp_sep *sep,
> }
>
> if (l != NULL) {
> + if (a2dp_sep_get_lock(tmp))
> + goto failed;
> setup->reconfigure = TRUE;
> if (avdtp_close(session, tmp->stream, FALSE) < 0) {
> error("avdtp_close failed");
Thanks for the patch! It's now in the upstream tree.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-08 16:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-08 15:13 [PATCH] Fix closing stream of locked sep when reconfiguring Luiz Augusto von Dentz
2010-09-08 16:48 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox