From: Johan Hedberg <johan.hedberg@gmail.com>
To: John Crosbie <john@excelfore.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Fix a2dp play when sample rate changed
Date: Tue, 26 Oct 2010 11:57:04 -0400 [thread overview]
Message-ID: <20101026155704.GA14408@jh-x301> (raw)
In-Reply-To: <AANLkTikksLAeocFsM5vO0rnvphgOo_CoF1ZA_wkABY=c@mail.gmail.com>
Hi John,
On Tue, Oct 26, 2010, John Crosbie wrote:
> I have found that playing a 48KHz wav file immediately after playing a
> 44.1K file (or vice-versa) with aplay will fail. After this failure
> no a2dp stream will play. The problem is that after determining the
> current avdtp stream doesn't match the new configuration the stream is
> closed and a reconfiguration is attempted but fails because
> setup->rsep is null. The patch below fixes the reconfiguration.
Thanks for the patch. In the future, please follow the proper coding
style (e.g. space between "if" and "(") and prepare the patches using
git format-patch. I went ahead and did this work manually for you this
time instead of asking you to resend since we're in the process of
preparing the next bluez release.
Johan
prev parent reply other threads:[~2010-10-26 15:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 15:32 [PATCH] Fix a2dp play when sample rate changed John Crosbie
2010-10-26 15:57 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101026155704.GA14408@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=john@excelfore.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox