[PATCH] Fix a2dp play when sample rate changed

[PATCH] Fix a2dp play when sample rate changed

[John Crosbie]

I have found that playing a 48KHz wav file immediately after playing a
44.1K file (or vice-versa) with aplay will fail.  After this failure
no a2dp stream will play.  The problem is that after determining the
current avdtp stream doesn't match the new configuration the stream is
closed and a reconfiguration is attempted but fails because
setup->rsep is null.  The patch below fixes the reconfiguration.

John Crosbie
Excelfore Corporation


diff --git a/audio/a2dp.c b/audio/a2dp.c
index 7a36132..b9b5e4a 100644
--- a/audio/a2dp.c
+++ b/audio/a2dp.c
@@ -1028,6 +1028,12 @@ static gboolean a2dp_reconfigure(gpointer data)
        struct a2dp_sep *sep = setup->sep;
        int posix_err;

+       if(!setup->rsep)
+               setup->rsep = avdtp_find_remote_sep(setup->session, sep->lsep);
        posix_err = avdtp_set_configuration(setup->session, setup->rsep,
                                                sep->lsep,
                                                setup->client_caps,

Re: [PATCH] Fix a2dp play when sample rate changed

[Johan Hedberg]

Hi John,

On Tue, Oct 26, 2010, John Crosbie wrote:
> I have found that playing a 48KHz wav file immediately after playing a
> 44.1K file (or vice-versa) with aplay will fail.  After this failure
> no a2dp stream will play.  The problem is that after determining the
> current avdtp stream doesn't match the new configuration the stream is
> closed and a reconfiguration is attempted but fails because
> setup->rsep is null.  The patch below fixes the reconfiguration.

Thanks for the patch. In the future, please follow the proper coding
style (e.g. space between "if" and "(") and prepare the patches using
git format-patch. I went ahead and did this work manually for you this
time instead of asking you to resend since we're in the process of
preparing the next bluez release.

Johan