[PATCH] Remove parameter entered from the DisplayPasskey agent method

[PATCH] Remove parameter entered from the DisplayPasskey agent method

[Jose Antonio Santos Cadenas]

In the current method implementation the parameter is not used.
---
 doc/agent-api.txt |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/doc/agent-api.txt b/doc/agent-api.txt
index d8d35c0..1ddd290 100644
--- a/doc/agent-api.txt
+++ b/doc/agent-api.txt
@@ -42,14 +42,11 @@ Methods		void Release()
 			Possible errors: org.bluez.Error.Rejected
 			                 org.bluez.Error.Canceled
 
-		void DisplayPasskey(object device, uint32 passkey, uint8 entered)
+		void DisplayPasskey(object device, uint32 passkey)
 
 			This method gets called when the service daemon
 			needs to display a passkey for an authentication.
 
-			The entered parameter indicates the number of already
-			typed keys on the remote side.
-
 			An empty reply should be returned. When the passkey
 			needs no longer to be displayed, the Cancel method
 			of the agent will be called.
-- 
1.7.1

Re: [PATCH] Remove parameter entered from the DisplayPasskey agent method

[Johan Hedberg]

Hi Jose,

On Sun, Nov 21, 2010, Jose Antonio Santos Cadenas wrote:
> In the current method implementation the parameter is not used.
> ---
>  doc/agent-api.txt |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)

Do you actually have a BT 2.1 keyboard to test this with? The right fix
is to fix the code and not the spec since we do want the UI to get the
hints about entered characters.

Johan

Re: [PATCH] Remove parameter entered from the DisplayPasskey agent method

[Jose Antonio Santos Cadenas]

Hi Johan,

2010/11/21 Johan Hedberg <johan.hedberg@gmail.com>:
> Hi Jose,
>
> On Sun, Nov 21, 2010, Jose Antonio Santos Cadenas wrote:
>> In the current method implementation the parameter is not used.
>> ---
>>  doc/agent-api.txt |    5 +----
>>  1 files changed, 1 insertions(+), 4 deletions(-)
>
> Do you actually have a BT 2.1 keyboard to test this with?

I'm lost, why do I need a BT keyboard?

> The right fix
> is to fix the code and not the spec since we do want the UI to get the
> hints about entered characters.

I also think that an other way to correct this is to change the code
to follow the specification, but as I see that the specification
didn't have changes since 2008 I thought that was an obsolete
documentation, because in the source code there is no reference to the
entered parameter. Have you got any suggestions about the better way
to add this parameter in order to follow the API in the documentation?
 Nevertheless I'll have a deeper look to the code looking for hints.

>
> Johan
>

Regards.

Jose.

Re: [PATCH] Remove parameter entered from the DisplayPasskey agent method

[Johan Hedberg]

Hi Jose,

On Sun, Nov 21, 2010, Jose Antonio Santos Cadenas wrote:
> > On Sun, Nov 21, 2010, Jose Antonio Santos Cadenas wrote:
> >> In the current method implementation the parameter is not used.
> >> ---
> >>  doc/agent-api.txt |    5 +----
> >>  1 files changed, 1 insertions(+), 4 deletions(-)
> >
> > Do you actually have a BT 2.1 keyboard to test this with?
> 
> I'm lost, why do I need a BT keyboard?

Because DisplayPasskey will only happen if the other side has
KeyboardOnly as its SSP IO capability.

> > The right fix
> > is to fix the code and not the spec since we do want the UI to get the
> > hints about entered characters.
> 
> I also think that an other way to correct this is to change the code
> to follow the specification, but as I see that the specification
> didn't have changes since 2008 I thought that was an obsolete
> documentation, because in the source code there is no reference to the
> entered parameter. Have you got any suggestions about the better way
> to add this parameter in order to follow the API in the documentation?
>  Nevertheless I'll have a deeper look to the code looking for hints.

The third parameter is supposed to be bound to the Keypress Notification
HCI event which should come when the remote side does a
HCI_Send_Keypress_Notification HCI command (again only a keyboard would
do something like this).

Johan

Re: [PATCH] Remove parameter entered from the DisplayPasskey agent method

[Jose Antonio Santos Cadenas]

Hi Johan,

2010/11/21 Johan Hedberg <johan.hedberg@gmail.com>:
> Hi Jose,
>
> On Sun, Nov 21, 2010, Jose Antonio Santos Cadenas wrote:
>> > On Sun, Nov 21, 2010, Jose Antonio Santos Cadenas wrote:
>> >> In the current method implementation the parameter is not used.
>> >> ---
>> >>  doc/agent-api.txt |    5 +----
>> >>  1 files changed, 1 insertions(+), 4 deletions(-)
>> >
>> > Do you actually have a BT 2.1 keyboard to test this with?
>>
>> I'm lost, why do I need a BT keyboard?
>
> Because DisplayPasskey will only happen if the other side has
> KeyboardOnly as its SSP IO capability.
>
>> > The right fix
>> > is to fix the code and not the spec since we do want the UI to get the
>> > hints about entered characters.
>>
>> I also think that an other way to correct this is to change the code
>> to follow the specification, but as I see that the specification
>> didn't have changes since 2008 I thought that was an obsolete
>> documentation, because in the source code there is no reference to the
>> entered parameter. Have you got any suggestions about the better way
>> to add this parameter in order to follow the API in the documentation?
>>  Nevertheless I'll have a deeper look to the code looking for hints.
>
> The third parameter is supposed to be bound to the Keypress Notification
> HCI event which should come when the remote side does a
> HCI_Send_Keypress_Notification HCI command (again only a keyboard would
> do something like this).

Thanks for the explanation now I understand the use of the method.
Unfortunately right now I don't have a 2.1 keyboard so I can't test
it.

>
> Johan
>

Jose.