From: Johan Hedberg <johan.hedberg@gmail.com>
To: Santiago Carot-Nemesio <sancane@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] Do not increment mdl reference in reconnections
Date: Mon, 22 Nov 2010 15:37:17 +0100 [thread overview]
Message-ID: <20101122143717.GB2303@jh-x301> (raw)
In-Reply-To: <1290413446-5391-1-git-send-email-sancane@gmail.com>
Hi,
On Mon, Nov 22, 2010, Santiago Carot-Nemesio wrote:
> diff --git a/health/hdp.c b/health/hdp.c
> index 2e06a6b..769e300 100644
> --- a/health/hdp.c
> +++ b/health/hdp.c
> @@ -921,7 +921,8 @@ static void hdp_mcap_mdl_connected_cb(struct mcap_mdl *mdl, void *data)
> return;
>
> chan = dev->ndc;
> - chan->mdl = mcap_mdl_ref(mdl);
> + if (!chan->mdl)
> + chan->mdl = mcap_mdl_ref(mdl);
>
> if (!g_slist_find(dev->channels, chan))
> dev->channels = g_slist_prepend(dev->channels,
Pushed upstream. Do try to be more verbose in your commit messages
please. Also have the summary lines of fix commits (like this one)
starting with "Fix ..." so they can be easily detected e.g. when doing
summaries for release changelogs.
Johan
prev parent reply other threads:[~2010-11-22 14:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 8:10 [PATCH 1/2] Do not increment mdl reference in reconnections Santiago Carot-Nemesio
2010-11-22 8:07 ` [PATCH 2/2] Increment reference counter when a io_watcher is added Jose Antonio Santos Cadenas
2010-11-22 14:43 ` Johan Hedberg
2010-11-22 14:54 ` Jose Antonio Santos Cadenas
2010-11-22 14:55 ` [PATCH 2/2] Fix: increment MDL and MCL reference counter in IO watchers Jose Antonio Santos Cadenas
2010-11-22 17:05 ` Johan Hedberg
2010-11-22 19:14 ` Jose Antonio Santos Cadenas
2010-11-22 14:37 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101122143717.GB2303@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=sancane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox