From: Johan Hedberg <johan.hedberg@gmail.com>
To: Jose Antonio Santos Cadenas <santoscadenas@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/2] Increment reference counter when a io_watcher is added
Date: Mon, 22 Nov 2010 15:43:01 +0100 [thread overview]
Message-ID: <20101122144301.GC2303@jh-x301> (raw)
In-Reply-To: <1290413266-3949-1-git-send-email-santoscadenas@gmail.com>
Hi Jose,
On Mon, Nov 22, 2010, Jose Antonio Santos Cadenas wrote:
> Also a destroy function is added in order to avoid memory leaks
> ---
> health/mcap.c | 28 +++++++++++++++++++---------
> 1 files changed, 19 insertions(+), 9 deletions(-)
The patch content itself is fine but you need to fix the commit message.
Now you have half of the info in the summary and half in the message
body (both halves being equaly relevant). The summary line should be a
summary of the whole patch (in this case it could be e.g. "Fix MDL
reference counting for IO watchers") and the body should contain the
details. So please reformulate, resend, and pay more attention to this
kind of things in the future. Thanks :)
Johan
next prev parent reply other threads:[~2010-11-22 14:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 8:10 [PATCH 1/2] Do not increment mdl reference in reconnections Santiago Carot-Nemesio
2010-11-22 8:07 ` [PATCH 2/2] Increment reference counter when a io_watcher is added Jose Antonio Santos Cadenas
2010-11-22 14:43 ` Johan Hedberg [this message]
2010-11-22 14:54 ` Jose Antonio Santos Cadenas
2010-11-22 14:55 ` [PATCH 2/2] Fix: increment MDL and MCL reference counter in IO watchers Jose Antonio Santos Cadenas
2010-11-22 17:05 ` Johan Hedberg
2010-11-22 19:14 ` Jose Antonio Santos Cadenas
2010-11-22 14:37 ` [PATCH 1/2] Do not increment mdl reference in reconnections Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101122144301.GC2303@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=santoscadenas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox