From: Johan Hedberg <johan.hedberg@gmail.com>
To: Michal Labedzki <michal.labedzki@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 3/3] More CodingStyle in lib and tools
Date: Mon, 20 Dec 2010 17:38:17 +0200 [thread overview]
Message-ID: <20101220153817.GB14575@jh-x301> (raw)
In-Reply-To: <1292840029-27770-4-git-send-email-michal.labedzki@tieto.com>
Hi Michal,
On Mon, Dec 20, 2010, Michal Labedzki wrote:
> --- a/lib/hci.c
> +++ b/lib/hci.c
> @@ -56,8 +56,8 @@ typedef struct {
>
> static int is_number(const char *c)
> {
> - while(*c) {
> - if (! isdigit(*c))
> + while (*c) {
> + if (!isdigit(*c))
> return 0;
> ++c;
Could you please merge this part to your first patch that introduced the
issue. Besides that the cleanups seem fine to me (after a very quick
look).
Johan
next prev parent reply other threads:[~2010-12-20 15:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 10:13 [PATCH] Tools user interface improve Michal Labedzki
2010-12-20 10:13 ` [PATCH 1/3] Filter device name in hciconfig Michal Labedzki
2010-12-21 8:30 ` [PATCH v2 " Michal Labedzki
2010-12-21 8:49 ` Johan Hedberg
2010-12-20 10:13 ` [PATCH 2/3] Fix tools UI to avoid program launch mistakes Michal Labedzki
2010-12-20 15:41 ` Johan Hedberg
2010-12-20 10:13 ` [PATCH 3/3] More CodingStyle in lib and tools Michal Labedzki
2010-12-20 15:38 ` Johan Hedberg [this message]
2010-12-21 8:34 ` [PATCH v2 " Michal Labedzki
2010-12-21 8:52 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101220153817.GB14575@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=michal.labedzki@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox