Re: [PATCH v2 1/3] Filter device name in hciconfig.

[Johan Hedberg <johan.hedberg@gmail.com>]

Hi Michal,

On Tue, Dec 21, 2010, Michal Labedzki wrote:
> No anymore work someting like "hciconfig tty1", "hciconfig qfg1" or
> "hciconfig hci1hg" as "hci1".
> ---
>  lib/hci.c         |   12 +++++++++++-
>  tools/hciconfig.c |   30 +++++++++++++++++++++++++++++-
>  2 files changed, 40 insertions(+), 2 deletions(-)

This doesn't compile for me:

lib/hci.c: In function 'is_number':
lib/hci.c:60: error: implicit declaration of function 'isdigit'

Did you actually compile using ./boostrap-configure? Always do that
before submitting patches. It'll enable some extra checks and convert
all warnings to errors so you don't miss them by mistake.

"man isdigit" tells me that <ctype.h> should be included to use the
funciton.

Also, your commit message doesn't match the patch content. The patch
also changes hci_devid which is in no way specific to hciconfig whereas
your commit message implies that the patch is specific to hciconfig.
Feel free to split this into two separate patches with appropriate
commit messages.

Johan