[PATCH resend] Bluetooth: l2cap: fix misuse of logical operation in place of bitop

[PATCH resend] Bluetooth: l2cap: fix misuse of logical operation in place of bitop

[David Sterba]

CC: Marcel Holtmann <marcel@holtmann.org>
CC: "Gustavo F. Padovan" <padovan@profusion.mobi>
CC: João Paulo Rechi Vita <jprvita@profusion.mobi>
Signed-off-by: David Sterba <dsterba@suse.cz>
---

Andrew, this has not been picked up by maintainers since 27.12., please consider it for -mm.

 net/bluetooth/l2cap.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c
index cd8f6ea..bdfdfdc 100644
--- a/net/bluetooth/l2cap.c
+++ b/net/bluetooth/l2cap.c
@@ -1893,8 +1893,8 @@ static int l2cap_sock_sendmsg(struct kiocb *iocb, struct socket *sock, struct ms
 		if (pi->mode == L2CAP_MODE_STREAMING) {
 			l2cap_streaming_send(sk);
 		} else {
-			if (pi->conn_state & L2CAP_CONN_REMOTE_BUSY &&
-					pi->conn_state && L2CAP_CONN_WAIT_F) {
+			if ((pi->conn_state & L2CAP_CONN_REMOTE_BUSY) &&
+					(pi->conn_state & L2CAP_CONN_WAIT_F)) {
 				err = len;
 				break;
 			}
-- 
1.7.3.4.626.g73e7b

Re: [PATCH resend] Bluetooth: l2cap: fix misuse of logical operation in place of bitop

[Gustavo F. Padovan]

Hi all,

* David Sterba <dsterba@suse.cz> [2011-01-14 14:59:44 +0100]:

> CC: Marcel Holtmann <marcel@holtmann.org>
> CC: "Gustavo F. Padovan" <padovan@profusion.mobi>
> CC: Jo=E3o Paulo Rechi Vita <jprvita@profusion.mobi>
> Signed-off-by: David Sterba <dsterba@suse.cz>
> ---
>=20
> Andrew, this has not been picked up by maintainers since 27.12., please c=
onsider it for -mm.
>=20
>  net/bluetooth/l2cap.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

I'm taking care of this. Sorry for the delay, I've been away a bit.
Patch is now applied to Bluetooth tree. Thanks.

--=20
Gustavo F. Padovan
http://profusion.mobi