From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: ankushbansal89@gmail.com, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Changing required GLIB version in acinclude.m4
Date: Thu, 3 Feb 2011 18:04:41 -0200 [thread overview]
Message-ID: <20110203200440.GD2168@joana> (raw)
In-Reply-To: <AANLkTi=DdZzYtadsTTOO6Y-R=8Sq7x+EX46g7UDYa-7m@mail.gmail.com>
Hi Luiz,
* Luiz Augusto von Dentz <luiz.dentz@gmail.com> [2011-02-03 10:46:08 +0200]:
> Hi,
>
> On Wed, Feb 2, 2011 at 10:04 PM, <ankushbansal89@gmail.com> wrote:
> > From: Ankush Bansal <ankushbansal89@gmail.com>
> >
> > ---
> > acinclude.m4 | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/acinclude.m4 b/acinclude.m4
> > index ecf4b4b..9d3f6b2 100644
> > --- a/acinclude.m4
> > +++ b/acinclude.m4
> > @@ -108,8 +108,8 @@ AC_DEFUN([AC_PATH_DBUS], [
> > ])
> >
> > AC_DEFUN([AC_PATH_GLIB], [
> > - PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.14, dummy=yes,
> > - AC_MSG_ERROR(GLib library version 2.14 or later is required))
> > + PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.16, dummy=yes,
> > + AC_MSG_ERROR(GLib library version 2.16 or later is required))
> > AC_SUBST(GLIB_CFLAGS)
> > AC_SUBST(GLIB_LIBS)
> > ])
> > --
> > 1.7.1
>
> Can you provide more details why this is needed, is there any new
> function we are using which requires 2.16?
It is g_strcmp0(), but it should be a good idea add this info to the commit
message.
--
Gustavo F. Padovan
http://profusion.mobi
next prev parent reply other threads:[~2011-02-03 20:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-02 20:04 [PATCH] Changing required GLIB version in acinclude.m4 ankushbansal89
2011-02-03 8:46 ` Luiz Augusto von Dentz
2011-02-03 20:04 ` Gustavo F. Padovan [this message]
2011-02-04 5:01 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110203200440.GD2168@joana \
--to=padovan@profusion.mobi \
--cc=ankushbansal89@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox