* [PATCH] Changing required GLIB version in acinclude.m4
@ 2011-02-02 20:04 ankushbansal89
2011-02-03 8:46 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 4+ messages in thread
From: ankushbansal89 @ 2011-02-02 20:04 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Ankush Bansal
From: Ankush Bansal <ankushbansal89@gmail.com>
---
acinclude.m4 | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/acinclude.m4 b/acinclude.m4
index ecf4b4b..9d3f6b2 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -108,8 +108,8 @@ AC_DEFUN([AC_PATH_DBUS], [
])
AC_DEFUN([AC_PATH_GLIB], [
- PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.14, dummy=yes,
- AC_MSG_ERROR(GLib library version 2.14 or later is required))
+ PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.16, dummy=yes,
+ AC_MSG_ERROR(GLib library version 2.16 or later is required))
AC_SUBST(GLIB_CFLAGS)
AC_SUBST(GLIB_LIBS)
])
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Changing required GLIB version in acinclude.m4
2011-02-02 20:04 [PATCH] Changing required GLIB version in acinclude.m4 ankushbansal89
@ 2011-02-03 8:46 ` Luiz Augusto von Dentz
2011-02-03 20:04 ` Gustavo F. Padovan
0 siblings, 1 reply; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2011-02-03 8:46 UTC (permalink / raw)
To: ankushbansal89; +Cc: linux-bluetooth
Hi,
On Wed, Feb 2, 2011 at 10:04 PM, <ankushbansal89@gmail.com> wrote:
> From: Ankush Bansal <ankushbansal89@gmail.com>
>
> ---
> acinclude.m4 | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/acinclude.m4 b/acinclude.m4
> index ecf4b4b..9d3f6b2 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -108,8 +108,8 @@ AC_DEFUN([AC_PATH_DBUS], [
> ])
>
> AC_DEFUN([AC_PATH_GLIB], [
> - PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.14, dummy=yes,
> - AC_MSG_ERROR(GLib library version 2.14 or later is required))
> + PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.16, dummy=yes,
> + AC_MSG_ERROR(GLib library version 2.16 or later is required))
> AC_SUBST(GLIB_CFLAGS)
> AC_SUBST(GLIB_LIBS)
> ])
> --
> 1.7.1
Can you provide more details why this is needed, is there any new
function we are using which requires 2.16?
--
Luiz Augusto von Dentz
Computer Engineer
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Changing required GLIB version in acinclude.m4
2011-02-03 8:46 ` Luiz Augusto von Dentz
@ 2011-02-03 20:04 ` Gustavo F. Padovan
2011-02-04 5:01 ` Johan Hedberg
0 siblings, 1 reply; 4+ messages in thread
From: Gustavo F. Padovan @ 2011-02-03 20:04 UTC (permalink / raw)
To: Luiz Augusto von Dentz; +Cc: ankushbansal89, linux-bluetooth
Hi Luiz,
* Luiz Augusto von Dentz <luiz.dentz@gmail.com> [2011-02-03 10:46:08 +0200]:
> Hi,
>
> On Wed, Feb 2, 2011 at 10:04 PM, <ankushbansal89@gmail.com> wrote:
> > From: Ankush Bansal <ankushbansal89@gmail.com>
> >
> > ---
> > acinclude.m4 | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/acinclude.m4 b/acinclude.m4
> > index ecf4b4b..9d3f6b2 100644
> > --- a/acinclude.m4
> > +++ b/acinclude.m4
> > @@ -108,8 +108,8 @@ AC_DEFUN([AC_PATH_DBUS], [
> > ])
> >
> > AC_DEFUN([AC_PATH_GLIB], [
> > - PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.14, dummy=yes,
> > - AC_MSG_ERROR(GLib library version 2.14 or later is required))
> > + PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.16, dummy=yes,
> > + AC_MSG_ERROR(GLib library version 2.16 or later is required))
> > AC_SUBST(GLIB_CFLAGS)
> > AC_SUBST(GLIB_LIBS)
> > ])
> > --
> > 1.7.1
>
> Can you provide more details why this is needed, is there any new
> function we are using which requires 2.16?
It is g_strcmp0(), but it should be a good idea add this info to the commit
message.
--
Gustavo F. Padovan
http://profusion.mobi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Changing required GLIB version in acinclude.m4
2011-02-03 20:04 ` Gustavo F. Padovan
@ 2011-02-04 5:01 ` Johan Hedberg
0 siblings, 0 replies; 4+ messages in thread
From: Johan Hedberg @ 2011-02-04 5:01 UTC (permalink / raw)
To: Gustavo F. Padovan
Cc: Luiz Augusto von Dentz, ankushbansal89, linux-bluetooth
Hi,
On Thu, Feb 03, 2011, Gustavo F. Padovan wrote:
> > Can you provide more details why this is needed, is there any new
> > function we are using which requires 2.16?
>
> It is g_strcmp0(), but it should be a good idea add this info to the commit
> message.
I went ahead and added this to the patch. It has now been pushed
upstream.
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-02-04 5:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-02 20:04 [PATCH] Changing required GLIB version in acinclude.m4 ankushbansal89
2011-02-03 8:46 ` Luiz Augusto von Dentz
2011-02-03 20:04 ` Gustavo F. Padovan
2011-02-04 5:01 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox