* [2.6.38-rc6, patch] fix hci_dev_list locking...
@ 2011-03-01 15:41 Daniel J Blueman
2011-03-01 15:49 ` [stable] " Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Daniel J Blueman @ 2011-03-01 15:41 UTC (permalink / raw)
To: linux-bluetooth; +Cc: stable
Release acquired lock on error path, fixing potential hang up.
Signed-off-by: Daniel J Blueman <daniel.blueman@gmail.com>
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index f827fd9..ace8726 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -111,8 +111,10 @@ static int read_index_list(struct sock *sk)
body_len = sizeof(*ev) + sizeof(*rp) + (2 * count);
skb = alloc_skb(sizeof(*hdr) + body_len, GFP_ATOMIC);
- if (!skb)
+ if (!skb) {
+ read_unlock(&hci_dev_list_lock);
return -ENOMEM;
+ }
hdr = (void *) skb_put(skb, sizeof(*hdr));
hdr->opcode = cpu_to_le16(MGMT_EV_CMD_COMPLETE);
--
Daniel J Blueman
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [stable] [2.6.38-rc6, patch] fix hci_dev_list locking...
2011-03-01 15:41 [2.6.38-rc6, patch] fix hci_dev_list locking Daniel J Blueman
@ 2011-03-01 15:49 ` Greg KH
2011-03-01 15:53 ` Daniel J Blueman
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2011-03-01 15:49 UTC (permalink / raw)
To: Daniel J Blueman; +Cc: linux-bluetooth, stable
On Tue, Mar 01, 2011 at 11:41:38PM +0800, Daniel J Blueman wrote:
> Release acquired lock on error path, fixing potential hang up.
>
> Signed-off-by: Daniel J Blueman <daniel.blueman@gmail.com>
>
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index f827fd9..ace8726 100644
Please go read Documentation/stable_kernel_rules.txt for how to properly
submit patches to the stable kernel tree (hint, this way was not
correct...)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [stable] [2.6.38-rc6, patch] fix hci_dev_list locking...
2011-03-01 15:49 ` [stable] " Greg KH
@ 2011-03-01 15:53 ` Daniel J Blueman
0 siblings, 0 replies; 3+ messages in thread
From: Daniel J Blueman @ 2011-03-01 15:53 UTC (permalink / raw)
To: Greg KH; +Cc: linux-bluetooth, stable
On 1 March 2011 23:49, Greg KH <greg@kroah.com> wrote:
> On Tue, Mar 01, 2011 at 11:41:38PM +0800, Daniel J Blueman wrote:
>> Release acquired lock on error path, fixing potential hang up.
>>
>> Signed-off-by: Daniel J Blueman <daniel.blueman@gmail.com>
>>
>> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
>> index f827fd9..ace8726 100644
>
> Please go read Documentation/stable_kernel_rules.txt for how to properly
> submit patches to the stable kernel tree (hint, this way was not
> correct...)
Good tip; I'll follow it up.
Thanks,
Daniel
--
Daniel J Blueman
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-01 15:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-01 15:41 [2.6.38-rc6, patch] fix hci_dev_list locking Daniel J Blueman
2011-03-01 15:49 ` [stable] " Greg KH
2011-03-01 15:53 ` Daniel J Blueman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox