* [PATCH] Remove unused variable in mgmtops plugin
@ 2011-03-29 14:42 Claudio Takahasi
2011-03-29 14:50 ` Johan Hedberg
0 siblings, 1 reply; 3+ messages in thread
From: Claudio Takahasi @ 2011-03-29 14:42 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Claudio Takahasi
---
plugins/mgmtops.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/plugins/mgmtops.c b/plugins/mgmtops.c
index 65b32e6..3f96017 100644
--- a/plugins/mgmtops.c
+++ b/plugins/mgmtops.c
@@ -1410,7 +1410,6 @@ static void mgmt_cleanup(void)
{
g_free(controllers);
controllers = NULL;
- max_index = -1;
if (mgmt_sock >= 0) {
close(mgmt_sock);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Remove unused variable in mgmtops plugin
2011-03-29 14:42 [PATCH] Remove unused variable in mgmtops plugin Claudio Takahasi
@ 2011-03-29 14:50 ` Johan Hedberg
2011-03-29 16:47 ` Claudio Takahasi
0 siblings, 1 reply; 3+ messages in thread
From: Johan Hedberg @ 2011-03-29 14:50 UTC (permalink / raw)
To: Claudio Takahasi; +Cc: linux-bluetooth
Hi Claudio,
On Tue, Mar 29, 2011, Claudio Takahasi wrote:
> ---
> plugins/mgmtops.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/plugins/mgmtops.c b/plugins/mgmtops.c
> index 65b32e6..3f96017 100644
> --- a/plugins/mgmtops.c
> +++ b/plugins/mgmtops.c
> @@ -1410,7 +1410,6 @@ static void mgmt_cleanup(void)
> {
> g_free(controllers);
> controllers = NULL;
> - max_index = -1;
>
> if (mgmt_sock >= 0) {
> close(mgmt_sock);
I don't understand the purpose of this patch. You're neither removing a
variable (just removing an assignment) nor is the variable you're
touching unused.
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Remove unused variable in mgmtops plugin
2011-03-29 14:50 ` Johan Hedberg
@ 2011-03-29 16:47 ` Claudio Takahasi
0 siblings, 0 replies; 3+ messages in thread
From: Claudio Takahasi @ 2011-03-29 16:47 UTC (permalink / raw)
To: Claudio Takahasi, linux-bluetooth; +Cc: Johan Hedberg
Hi Johan,
On Tue, Mar 29, 2011 at 2:50 PM, Johan Hedberg <johan.hedberg@gmail.com> wrote:
> Hi Claudio,
>
> On Tue, Mar 29, 2011, Claudio Takahasi wrote:
>> ---
>> plugins/mgmtops.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/plugins/mgmtops.c b/plugins/mgmtops.c
>> index 65b32e6..3f96017 100644
>> --- a/plugins/mgmtops.c
>> +++ b/plugins/mgmtops.c
>> @@ -1410,7 +1410,6 @@ static void mgmt_cleanup(void)
>> {
>> g_free(controllers);
>> controllers = NULL;
>> - max_index = -1;
>>
>> if (mgmt_sock >= 0) {
>> close(mgmt_sock);
>
> I don't understand the purpose of this patch. You're neither removing a
> variable (just removing an assignment) nor is the variable you're
> touching unused.
>
> Johan
>
No comment!
I am not working drunk! Maybe blind! ;-)
Claudio.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-29 16:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-29 14:42 [PATCH] Remove unused variable in mgmtops plugin Claudio Takahasi
2011-03-29 14:50 ` Johan Hedberg
2011-03-29 16:47 ` Claudio Takahasi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox