From: Johan Hedberg <johan.hedberg@gmail.com>
To: Santiago Carot-Nemesio <sancane@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 4/9] Add functions to manage attio callbacks
Date: Mon, 10 Oct 2011 10:22:59 +0300 [thread overview]
Message-ID: <20111010072259.GE4094@fusion.localdomain> (raw)
In-Reply-To: <1317303988-26310-5-git-send-email-sancane@gmail.com>
Hi Santiago,
On Thu, Sep 29, 2011, Santiago Carot-Nemesio wrote:
> @@ -36,7 +37,9 @@
> struct thermometer {
> DBusConnection *conn; /* The connection to the bus */
> struct btd_device *dev; /* Device reference */
> + GAttrib *attrib; /* GATT connection */
> struct att_range *svc_range; /* Thermometer range */
> + gint attioid; /* Att watcher id */
> };
Looking at the attio.h API, the attioid should be guint and not gint,
right? Also, this struct has the same inconsistency in indentation. Some
lines use spaces whereas other use tabs. Please fix this (though
potentially in a separate coding-style cleanup patch since the
inconsistency exists there already before this patch).
> + if (t->attioid)
> + btd_device_remove_attio_callback(t->dev, t->attioid);
Please use if (t->attioid > 0)
Johan
next prev parent reply other threads:[~2011-10-10 7:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 13:46 Health Thermometer Profile patches Santiago Carot-Nemesio
2011-09-29 13:46 ` [PATCH 1/9] Get thermometer service range to load the driver Santiago Carot-Nemesio
2011-09-29 13:46 ` [PATCH 2/9] Register Health Thermometer Interface Santiago Carot-Nemesio
2011-09-29 13:46 ` [PATCH 3/9] Unregister " Santiago Carot-Nemesio
2011-09-29 13:46 ` [PATCH 4/9] Add functions to manage attio callbacks Santiago Carot-Nemesio
2011-09-29 13:46 ` [PATCH 5/9] Add handler function to manage GATT indications Santiago Carot-Nemesio
2011-09-29 13:46 ` [PATCH 6/9] Get all characteristics in thermometer service Santiago Carot-Nemesio
2011-09-29 13:46 ` [PATCH 7/9] Read temperature type characteristic Santiago Carot-Nemesio
2011-09-29 13:46 ` [PATCH 8/9] Read measurement interval characteristic Santiago Carot-Nemesio
2011-09-29 13:46 ` [PATCH 9/9] Set Intermediate property if intermediate temp. characteristic is supported Santiago Carot-Nemesio
2011-10-10 7:35 ` [PATCH 8/9] Read measurement interval characteristic Johan Hedberg
2011-10-10 8:04 ` Santiago Carot
2011-10-10 7:32 ` [PATCH 7/9] Read temperature type characteristic Johan Hedberg
2011-10-10 7:28 ` [PATCH 6/9] Get all characteristics in thermometer service Johan Hedberg
2011-10-10 7:24 ` [PATCH 5/9] Add handler function to manage GATT indications Johan Hedberg
2011-10-10 7:22 ` Johan Hedberg [this message]
2011-10-10 7:19 ` [PATCH 3/9] Unregister Health Thermometer Interface Johan Hedberg
2011-10-10 7:19 ` [PATCH 2/9] Register " Johan Hedberg
2011-10-10 7:16 ` [PATCH 1/9] Get thermometer service range to load the driver Johan Hedberg
-- strict thread matches above, loose matches on Subject: below --
2011-10-13 15:29 Health Thermometer Profile Santiago Carot-Nemesio
2011-10-13 15:29 ` [PATCH 1/9] Get thermometer service range to load the driver Santiago Carot-Nemesio
2011-10-13 15:29 ` [PATCH 2/9] Register Health Thermometer Interface Santiago Carot-Nemesio
2011-10-13 15:29 ` [PATCH 3/9] Unregister " Santiago Carot-Nemesio
2011-10-13 15:29 ` [PATCH 4/9] Add functions to manage attio callbacks Santiago Carot-Nemesio
2011-09-28 17:48 Health Thermometer Profile patches Santiago Carot-Nemesio
2011-09-28 17:48 ` [PATCH 1/9] Get thermometer service range to load the driver Santiago Carot-Nemesio
2011-09-28 17:48 ` [PATCH 2/9] Register Health Thermometer Interface Santiago Carot-Nemesio
2011-09-28 17:48 ` [PATCH 3/9] Unregister " Santiago Carot-Nemesio
2011-09-28 17:48 ` [PATCH 4/9] Add functions to manage attio callbacks Santiago Carot-Nemesio
2011-09-19 8:52 Santiago Carot-Nemesio
2011-09-19 8:52 ` [PATCH 1/9] Load device driver if thermometer service attribute appears in GATT Santiago Carot-Nemesio
2011-09-19 8:52 ` [PATCH 2/9] Register Health Thermometer Interface Santiago Carot-Nemesio
2011-09-19 8:52 ` [PATCH 3/9] Unregister " Santiago Carot-Nemesio
2011-09-19 8:52 ` [PATCH 4/9] Add functions to manage attio callbacks Santiago Carot-Nemesio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111010072259.GE4094@fusion.localdomain \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=sancane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox