From: Johan Hedberg <johan.hedberg@gmail.com>
To: Santiago Carot-Nemesio <sancane@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 7/9] Read temperature type characteristic
Date: Mon, 10 Oct 2011 10:32:24 +0300 [thread overview]
Message-ID: <20111010073224.GH4094@fusion.localdomain> (raw)
In-Reply-To: <1317303988-26310-8-git-send-email-sancane@gmail.com>
On Thu, Sep 29, 2011, Santiago Carot-Nemesio wrote:
> @@ -113,7 +120,29 @@ static void discover_desc_cb(guint8 status, const guint8 *pdu, guint16 len,
> static void read_temp_type_cb(guint8 status, const guint8 *pdu, guint16 len,
> gpointer user_data)
> {
> - /* TODO */
> + struct characteristic *ch = user_data;
> + struct thermometer *t = ch->t;
> + uint8_t value[ATT_MAX_MTU];
> + int vlen;
> +
> + if (status != 0) {
This is correct. So why did you have "if (status)" in the previous
patch?
> + t->type = (uint8_t) value[0];
This looks like an unnecessary explicit type-cast. The array is already
of type uint8_t.
Johan
next prev parent reply other threads:[~2011-10-10 7:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 13:46 Health Thermometer Profile patches Santiago Carot-Nemesio
2011-09-29 13:46 ` [PATCH 1/9] Get thermometer service range to load the driver Santiago Carot-Nemesio
2011-09-29 13:46 ` [PATCH 2/9] Register Health Thermometer Interface Santiago Carot-Nemesio
2011-09-29 13:46 ` [PATCH 3/9] Unregister " Santiago Carot-Nemesio
2011-09-29 13:46 ` [PATCH 4/9] Add functions to manage attio callbacks Santiago Carot-Nemesio
2011-09-29 13:46 ` [PATCH 5/9] Add handler function to manage GATT indications Santiago Carot-Nemesio
2011-09-29 13:46 ` [PATCH 6/9] Get all characteristics in thermometer service Santiago Carot-Nemesio
2011-09-29 13:46 ` [PATCH 7/9] Read temperature type characteristic Santiago Carot-Nemesio
2011-09-29 13:46 ` [PATCH 8/9] Read measurement interval characteristic Santiago Carot-Nemesio
2011-09-29 13:46 ` [PATCH 9/9] Set Intermediate property if intermediate temp. characteristic is supported Santiago Carot-Nemesio
2011-10-10 7:35 ` [PATCH 8/9] Read measurement interval characteristic Johan Hedberg
2011-10-10 8:04 ` Santiago Carot
2011-10-10 7:32 ` Johan Hedberg [this message]
2011-10-10 7:28 ` [PATCH 6/9] Get all characteristics in thermometer service Johan Hedberg
2011-10-10 7:24 ` [PATCH 5/9] Add handler function to manage GATT indications Johan Hedberg
2011-10-10 7:22 ` [PATCH 4/9] Add functions to manage attio callbacks Johan Hedberg
2011-10-10 7:19 ` [PATCH 3/9] Unregister Health Thermometer Interface Johan Hedberg
2011-10-10 7:19 ` [PATCH 2/9] Register " Johan Hedberg
2011-10-10 7:16 ` [PATCH 1/9] Get thermometer service range to load the driver Johan Hedberg
-- strict thread matches above, loose matches on Subject: below --
2011-10-13 15:29 Health Thermometer Profile Santiago Carot-Nemesio
2011-10-13 15:29 ` [PATCH 1/9] Get thermometer service range to load the driver Santiago Carot-Nemesio
2011-10-13 15:29 ` [PATCH 2/9] Register Health Thermometer Interface Santiago Carot-Nemesio
2011-10-13 15:29 ` [PATCH 3/9] Unregister " Santiago Carot-Nemesio
2011-10-13 15:29 ` [PATCH 4/9] Add functions to manage attio callbacks Santiago Carot-Nemesio
2011-10-13 15:29 ` [PATCH 5/9] Add handler function to manage GATT indications Santiago Carot-Nemesio
2011-10-13 15:29 ` [PATCH 6/9] Get all characteristics in thermometer service Santiago Carot-Nemesio
2011-10-13 15:29 ` [PATCH 7/9] Read temperature type characteristic Santiago Carot-Nemesio
2011-09-28 17:48 Health Thermometer Profile patches Santiago Carot-Nemesio
2011-09-28 17:48 ` [PATCH 1/9] Get thermometer service range to load the driver Santiago Carot-Nemesio
2011-09-28 17:48 ` [PATCH 2/9] Register Health Thermometer Interface Santiago Carot-Nemesio
2011-09-28 17:48 ` [PATCH 3/9] Unregister " Santiago Carot-Nemesio
2011-09-28 17:48 ` [PATCH 4/9] Add functions to manage attio callbacks Santiago Carot-Nemesio
2011-09-28 17:48 ` [PATCH 5/9] Add handler function to manage GATT indications Santiago Carot-Nemesio
2011-09-28 17:48 ` [PATCH 6/9] Get all characteristics in thermometer service Santiago Carot-Nemesio
2011-09-28 17:48 ` [PATCH 7/9] Read temperature type characteristic Santiago Carot-Nemesio
2011-09-28 18:26 ` Anderson Lizardo
2011-09-29 13:41 ` Santiago Carot
2011-09-19 8:52 Santiago Carot-Nemesio
2011-09-19 8:52 ` [PATCH 1/9] Load device driver if thermometer service attribute appears in GATT Santiago Carot-Nemesio
2011-09-19 8:52 ` [PATCH 2/9] Register Health Thermometer Interface Santiago Carot-Nemesio
2011-09-19 8:52 ` [PATCH 3/9] Unregister " Santiago Carot-Nemesio
2011-09-19 8:52 ` [PATCH 4/9] Add functions to manage attio callbacks Santiago Carot-Nemesio
2011-09-19 8:52 ` [PATCH 5/9] Add handler function to manage GATT indications Santiago Carot-Nemesio
2011-09-19 8:52 ` [PATCH 6/9] Get all characteristics in thermometer service Santiago Carot-Nemesio
2011-09-19 8:52 ` [PATCH 7/9] Read temperature type characteristic Santiago Carot-Nemesio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111010073224.GH4094@fusion.localdomain \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=sancane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox