* [PATCH BlueZ v2 0/1] Fix call status in +CLCC for maemo6 telephony
@ 2011-10-11 11:34 Dmitriy Paliy
2011-10-11 11:34 ` [PATCH BlueZ v2] " Dmitriy Paliy
0 siblings, 1 reply; 4+ messages in thread
From: Dmitriy Paliy @ 2011-10-11 11:34 UTC (permalink / raw)
To: linux-bluetooth
Hi,
Comments of Luiz are taken into account in this version.
Dmitriy
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH BlueZ v2] Fix call status in +CLCC for maemo6 telephony
2011-10-11 11:34 [PATCH BlueZ v2 0/1] Fix call status in +CLCC for maemo6 telephony Dmitriy Paliy
@ 2011-10-11 11:34 ` Dmitriy Paliy
2011-10-11 12:12 ` Luiz Augusto von Dentz
2011-10-12 7:54 ` Johan Hedberg
0 siblings, 2 replies; 4+ messages in thread
From: Dmitriy Paliy @ 2011-10-11 11:34 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Dmitriy Paliy
If list current calls is requested when there is second incoming call
and csd call status is CSD_CALL_STATUS_PROCEEDING, then returned 'state
of the call' value in +CLCC is 4 (incoming, MT call), which is incorrect.
Indication than proceeds from incoming to waiting state.
This patch sets the corresponding value to 5 (waiting, MT call) in
maemo6 telephony driver for the second call.
---
audio/telephony-maemo6.c | 12 ++++++++++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/audio/telephony-maemo6.c b/audio/telephony-maemo6.c
index 102daeb..82cb274 100644
--- a/audio/telephony-maemo6.c
+++ b/audio/telephony-maemo6.c
@@ -932,8 +932,16 @@ static int csd_status_to_hfp(struct csd_call *call)
/* PROCEEDING can happen in outgoing/incoming */
if (call->originating)
return CALL_STATUS_DIALING;
- else
- return CALL_STATUS_INCOMING;
+
+ /*
+ * PROCEEDING is followed by WAITING CSD status, therefore
+ * second incoming call status indication is set immediately
+ * to waiting.
+ */
+ if (g_slist_length(active_calls) > 0)
+ return CALL_STATUS_WAITING;
+
+ return CALL_STATUS_INCOMING;
case CSD_CALL_STATUS_COMING:
return CALL_STATUS_INCOMING;
case CSD_CALL_STATUS_MO_ALERTING:
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH BlueZ v2] Fix call status in +CLCC for maemo6 telephony
2011-10-11 11:34 ` [PATCH BlueZ v2] " Dmitriy Paliy
@ 2011-10-11 12:12 ` Luiz Augusto von Dentz
2011-10-12 7:54 ` Johan Hedberg
1 sibling, 0 replies; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2011-10-11 12:12 UTC (permalink / raw)
To: Dmitriy Paliy; +Cc: linux-bluetooth
Hi Dmitriy,
On Tue, Oct 11, 2011 at 2:34 PM, Dmitriy Paliy <dmitriy.paliy@nokia.com> wrote:
> If list current calls is requested when there is second incoming call
> and csd call status is CSD_CALL_STATUS_PROCEEDING, then returned 'state
> of the call' value in +CLCC is 4 (incoming, MT call), which is incorrect.
> Indication than proceeds from incoming to waiting state.
>
> This patch sets the corresponding value to 5 (waiting, MT call) in
> maemo6 telephony driver for the second call.
> ---
> audio/telephony-maemo6.c | 12 ++++++++++--
> 1 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/audio/telephony-maemo6.c b/audio/telephony-maemo6.c
> index 102daeb..82cb274 100644
> --- a/audio/telephony-maemo6.c
> +++ b/audio/telephony-maemo6.c
> @@ -932,8 +932,16 @@ static int csd_status_to_hfp(struct csd_call *call)
> /* PROCEEDING can happen in outgoing/incoming */
> if (call->originating)
> return CALL_STATUS_DIALING;
> - else
> - return CALL_STATUS_INCOMING;
> +
> + /*
> + * PROCEEDING is followed by WAITING CSD status, therefore
> + * second incoming call status indication is set immediately
> + * to waiting.
> + */
> + if (g_slist_length(active_calls) > 0)
> + return CALL_STATUS_WAITING;
> +
> + return CALL_STATUS_INCOMING;
> case CSD_CALL_STATUS_COMING:
> return CALL_STATUS_INCOMING;
> case CSD_CALL_STATUS_MO_ALERTING:
> --
> 1.7.4.1
>
Ack.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH BlueZ v2] Fix call status in +CLCC for maemo6 telephony
2011-10-11 11:34 ` [PATCH BlueZ v2] " Dmitriy Paliy
2011-10-11 12:12 ` Luiz Augusto von Dentz
@ 2011-10-12 7:54 ` Johan Hedberg
1 sibling, 0 replies; 4+ messages in thread
From: Johan Hedberg @ 2011-10-12 7:54 UTC (permalink / raw)
To: Dmitriy Paliy; +Cc: linux-bluetooth
Hi Dmitriy,
On Tue, Oct 11, 2011, Dmitriy Paliy wrote:
> If list current calls is requested when there is second incoming call
> and csd call status is CSD_CALL_STATUS_PROCEEDING, then returned 'state
> of the call' value in +CLCC is 4 (incoming, MT call), which is incorrect.
> Indication than proceeds from incoming to waiting state.
>
> This patch sets the corresponding value to 5 (waiting, MT call) in
> maemo6 telephony driver for the second call.
> ---
> audio/telephony-maemo6.c | 12 ++++++++++--
> 1 files changed, 10 insertions(+), 2 deletions(-)
Applied. Thanks.
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-12 7:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-11 11:34 [PATCH BlueZ v2 0/1] Fix call status in +CLCC for maemo6 telephony Dmitriy Paliy
2011-10-11 11:34 ` [PATCH BlueZ v2] " Dmitriy Paliy
2011-10-11 12:12 ` Luiz Augusto von Dentz
2011-10-12 7:54 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox