Linux bluetooth development
 help / color / mirror / Atom feed
* [PATCH] Fix input pending connect handling
@ 2011-10-17 12:07 chanyeol.park
  2011-10-17 13:36 ` Johan Hedberg
  0 siblings, 1 reply; 2+ messages in thread
From: chanyeol.park @ 2011-10-17 12:07 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: chanyeol.park

From: Chan-yeol Park <chanyeol.park@samsung.com>

iconn->pending_connect needs to be freed after sending the error reply
---
 input/device.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/input/device.c b/input/device.c
index 9ff7f20..16eb155 100644
--- a/input/device.c
+++ b/input/device.c
@@ -825,6 +825,9 @@ failed:
 	reply = btd_error_failed(iconn->pending_connect, err_msg);
 	g_dbus_send_message(idev->conn, reply);
 
+	dbus_message_unref(iconn->pending_connect);
+	iconn->pending_connect = NULL;
+
 	/* So we guarantee the interrupt channel is closed before the
 	 * control channel (if we only do unref GLib will close it only
 	 * after returning control to the mainloop */
-- 
1.7.4.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix input pending connect handling
  2011-10-17 12:07 [PATCH] Fix input pending connect handling chanyeol.park
@ 2011-10-17 13:36 ` Johan Hedberg
  0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2011-10-17 13:36 UTC (permalink / raw)
  To: chanyeol.park; +Cc: linux-bluetooth

Hi Chan-yeol,

On Mon, Oct 17, 2011, chanyeol.park@samsung.com wrote:
> iconn->pending_connect needs to be freed after sending the error reply
> ---
>  input/device.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)

Applied. Thanks, and congrats for getting your first patch upstream! :)

Johan

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-10-17 13:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-17 12:07 [PATCH] Fix input pending connect handling chanyeol.park
2011-10-17 13:36 ` Johan Hedberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox