* [PATCH obexd] gobex: add missing checks for config.h
@ 2011-10-18 8:12 Luiz Augusto von Dentz
2011-10-18 8:22 ` Johan Hedberg
2011-10-18 15:51 ` Marcel Holtmann
0 siblings, 2 replies; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2011-10-18 8:12 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
---
gobex/gobex-defs.c | 4 ++++
| 4 ++++
gobex/gobex-packet.c | 4 ++++
3 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/gobex/gobex-defs.c b/gobex/gobex-defs.c
index f1f3b38..beb773d 100644
--- a/gobex/gobex-defs.c
+++ b/gobex/gobex-defs.c
@@ -19,6 +19,10 @@
*
*/
+#ifdef HAVE_CONFIG_H
+# include "config.h"
+#endif
+
#include <glib.h>
#include "gobex-defs.h"
--git a/gobex/gobex-header.c b/gobex/gobex-header.c
index e70d5e4..da982a7 100644
--- a/gobex/gobex-header.c
+++ b/gobex/gobex-header.c
@@ -19,6 +19,10 @@
*
*/
+#ifdef HAVE_CONFIG_H
+# include "config.h"
+#endif
+
#include <string.h>
#include "gobex-header.h"
diff --git a/gobex/gobex-packet.c b/gobex/gobex-packet.c
index d59bbce..b539430 100644
--- a/gobex/gobex-packet.c
+++ b/gobex/gobex-packet.c
@@ -19,6 +19,10 @@
*
*/
+#ifdef HAVE_CONFIG_H
+# include "config.h"
+#endif
+
#include <string.h>
#include <errno.h>
--
1.7.6.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH obexd] gobex: add missing checks for config.h
2011-10-18 8:12 [PATCH obexd] gobex: add missing checks for config.h Luiz Augusto von Dentz
@ 2011-10-18 8:22 ` Johan Hedberg
2011-10-18 15:51 ` Marcel Holtmann
1 sibling, 0 replies; 4+ messages in thread
From: Johan Hedberg @ 2011-10-18 8:22 UTC (permalink / raw)
To: Luiz Augusto von Dentz; +Cc: linux-bluetooth
Hi Luiz,
On Tue, Oct 18, 2011, Luiz Augusto von Dentz wrote:
> ---
> gobex/gobex-defs.c | 4 ++++
> gobex/gobex-header.c | 4 ++++
> gobex/gobex-packet.c | 4 ++++
> 3 files changed, 12 insertions(+), 0 deletions(-)
Applied. Thanks.
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH obexd] gobex: add missing checks for config.h
2011-10-18 8:12 [PATCH obexd] gobex: add missing checks for config.h Luiz Augusto von Dentz
2011-10-18 8:22 ` Johan Hedberg
@ 2011-10-18 15:51 ` Marcel Holtmann
2011-10-18 22:04 ` Luiz Augusto von Dentz
1 sibling, 1 reply; 4+ messages in thread
From: Marcel Holtmann @ 2011-10-18 15:51 UTC (permalink / raw)
To: Luiz Augusto von Dentz; +Cc: linux-bluetooth
Hi Luiz,
> gobex/gobex-defs.c | 4 ++++
> gobex/gobex-header.c | 4 ++++
> gobex/gobex-packet.c | 4 ++++
> 3 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/gobex/gobex-defs.c b/gobex/gobex-defs.c
> index f1f3b38..beb773d 100644
> --- a/gobex/gobex-defs.c
> +++ b/gobex/gobex-defs.c
> @@ -19,6 +19,10 @@
> *
> */
>
> +#ifdef HAVE_CONFIG_H
> +# include "config.h"
what is this space between # and include doing here. Please remove that.
And it is <config.h> and not "config.h".
Regards
Marcel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH obexd] gobex: add missing checks for config.h
2011-10-18 15:51 ` Marcel Holtmann
@ 2011-10-18 22:04 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2011-10-18 22:04 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: linux-bluetooth
Hi Marcel,
On Tue, Oct 18, 2011 at 6:51 PM, Marcel Holtmann <marcel@holtmann.org> wrot=
e:
> Hi Luiz,
>
>> =A0gobex/gobex-defs.c =A0 | =A0 =A04 ++++
>> =A0gobex/gobex-header.c | =A0 =A04 ++++
>> =A0gobex/gobex-packet.c | =A0 =A04 ++++
>> =A03 files changed, 12 insertions(+), 0 deletions(-)
>>
>> diff --git a/gobex/gobex-defs.c b/gobex/gobex-defs.c
>> index f1f3b38..beb773d 100644
>> --- a/gobex/gobex-defs.c
>> +++ b/gobex/gobex-defs.c
>> @@ -19,6 +19,10 @@
>> =A0 *
>> =A0 */
>>
>> +#ifdef HAVE_CONFIG_H
>> +# include "config.h"
>
> what is this space between # and include doing here. Please remove that.
>
> And it is <config.h> and not "config.h".
Copy/paste, well I guess while Im at it I can change all other places
to be consistent with what you are saying.
--=20
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-18 22:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-18 8:12 [PATCH obexd] gobex: add missing checks for config.h Luiz Augusto von Dentz
2011-10-18 8:22 ` Johan Hedberg
2011-10-18 15:51 ` Marcel Holtmann
2011-10-18 22:04 ` Luiz Augusto von Dentz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox