Linux bluetooth development
 help / color / mirror / Atom feed
* [PATCHv2] Bluetooth: Initialize tx_win_max for fixed channel
@ 2011-11-02  7:57 Emeltchenko Andrei
  2011-11-02 14:17 ` Marcel Holtmann
  2011-11-03 14:26 ` Gustavo Padovan
  0 siblings, 2 replies; 3+ messages in thread
From: Emeltchenko Andrei @ 2011-11-02  7:57 UTC (permalink / raw)
  To: linux-bluetooth

From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>

tx_win_max is initialized during L2CAP configuration phase. For fixed
channels (e.g. A2MP) we want to have it initialized when channel is
created.

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
---
 net/bluetooth/l2cap_sock.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c
index 646aefc..9ed6501 100644
--- a/net/bluetooth/l2cap_sock.c
+++ b/net/bluetooth/l2cap_sock.c
@@ -943,6 +943,7 @@ static void l2cap_sock_init(struct sock *sk, struct sock *parent)
 		chan->fcs  = pchan->fcs;
 		chan->max_tx = pchan->max_tx;
 		chan->tx_win = pchan->tx_win;
+		chan->tx_win_max = pchan->tx_win_max;
 		chan->sec_level = pchan->sec_level;
 		chan->flags = pchan->flags;
 	} else {
@@ -971,6 +972,7 @@ static void l2cap_sock_init(struct sock *sk, struct sock *parent)
 		chan->max_tx = L2CAP_DEFAULT_MAX_TX;
 		chan->fcs  = L2CAP_FCS_CRC16;
 		chan->tx_win = L2CAP_DEFAULT_TX_WINDOW;
+		chan->tx_win_max = L2CAP_DEFAULT_TX_WINDOW;
 		chan->sec_level = BT_SECURITY_LOW;
 		chan->flags = 0;
 		set_bit(FLAG_FORCE_ACTIVE, &chan->flags);
-- 
1.7.4.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCHv2] Bluetooth: Initialize tx_win_max for fixed channel
  2011-11-02  7:57 [PATCHv2] Bluetooth: Initialize tx_win_max for fixed channel Emeltchenko Andrei
@ 2011-11-02 14:17 ` Marcel Holtmann
  2011-11-03 14:26 ` Gustavo Padovan
  1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2011-11-02 14:17 UTC (permalink / raw)
  To: Emeltchenko Andrei; +Cc: linux-bluetooth

Hi Andrei,

> tx_win_max is initialized during L2CAP configuration phase. For fixed
> channels (e.g. A2MP) we want to have it initialized when channel is
> created.
> 
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
>  net/bluetooth/l2cap_sock.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

if there are no objections from anybody else, I am fine with this.

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Regards

Marcel



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCHv2] Bluetooth: Initialize tx_win_max for fixed channel
  2011-11-02  7:57 [PATCHv2] Bluetooth: Initialize tx_win_max for fixed channel Emeltchenko Andrei
  2011-11-02 14:17 ` Marcel Holtmann
@ 2011-11-03 14:26 ` Gustavo Padovan
  1 sibling, 0 replies; 3+ messages in thread
From: Gustavo Padovan @ 2011-11-03 14:26 UTC (permalink / raw)
  To: Emeltchenko Andrei; +Cc: linux-bluetooth

Hi Luiz,

* Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com> [2011-11-02 09:57:10 +0200]:

> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> 
> tx_win_max is initialized during L2CAP configuration phase. For fixed
> channels (e.g. A2MP) we want to have it initialized when channel is
> created.
> 
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
>  net/bluetooth/l2cap_sock.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

Applied, thanks.

	Gustavo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-11-03 14:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-02  7:57 [PATCHv2] Bluetooth: Initialize tx_win_max for fixed channel Emeltchenko Andrei
2011-11-02 14:17 ` Marcel Holtmann
2011-11-03 14:26 ` Gustavo Padovan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox