[PATCH BlueZ] btmgmt: fix used without initialization

[PATCH BlueZ] btmgmt: fix used without initialization

[Claudio Takahasi]

This patch fixes the following warning being treated as error:
mgmt/main.c: In function 'mgmt_process_data':
mgmt/main.c:508:3: error: 'len' may be used uninitialized in this
function [-Werror=uninitialized]
---
 mgmt/main.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/mgmt/main.c b/mgmt/main.c
index c970f62..d939cca 100644
--- a/mgmt/main.c
+++ b/mgmt/main.c
@@ -504,8 +504,10 @@ static int mgmt_process_data(int mgmt_sk)
 
 	ret = read(mgmt_sk, buf, sizeof(buf));
 	if (ret < 0) {
-		fprintf(stderr, "read: %s\n", strerror(errno));
-		return len;
+		int err = errno;
+
+		fprintf(stderr, "read: %s\n", strerror(err));
+		return -err;
 	}
 
 	if (ret < MGMT_HDR_SIZE) {
-- 
1.7.7.2

Re: [PATCH BlueZ] btmgmt: fix used without initialization

[Johan Hedberg]

Hi Claudio,

On Mon, Nov 07, 2011, Claudio Takahasi wrote:
> This patch fixes the following warning being treated as error:
> mgmt/main.c: In function 'mgmt_process_data':
> mgmt/main.c:508:3: error: 'len' may be used uninitialized in this
> function [-Werror=uninitialized]
> ---
>  mgmt/main.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)

Thanks for the heads-up. Seems like my gcc is buggy since it doesn't
catch this even when I use bootstrap-configure. The original intent of
the code was to have return ret which is what I pushed as a fix (-errno
would be more sophisticated but then it'd make sense to fix several
other places in the code too). Btw, please keep "int err" variables
negative so that we have consistency in the code-base and avoid stupid
bugs.

Johan

Re: [PATCH BlueZ] btmgmt: fix used without initialization

[Anderson Lizardo]

Hi Johan,

On Mon, Nov 7, 2011 at 3:36 PM, Johan Hedberg <johan.hedberg@gmail.com> wrote:
> Hi Claudio,
>
> On Mon, Nov 07, 2011, Claudio Takahasi wrote:
>> This patch fixes the following warning being treated as error:
>> mgmt/main.c: In function 'mgmt_process_data':
>> mgmt/main.c:508:3: error: 'len' may be used uninitialized in this
>> function [-Werror=uninitialized]
>> ---
>>  mgmt/main.c |    6 ++++--
>>  1 files changed, 4 insertions(+), 2 deletions(-)
>
> Thanks for the heads-up. Seems like my gcc is buggy since it doesn't
> catch this even when I use bootstrap-configure. The original intent of
> the code was to have return ret which is what I pushed as a fix (-errno
> would be more sophisticated but then it'd make sense to fix several
> other places in the code too). Btw, please keep "int err" variables
> negative so that we have consistency in the code-base and avoid stupid
> bugs.

Actually we are not consistent yet:

$ grep -r 'int err.*errno;' *
audio/avdtp.c:		int err = -errno;
audio/avdtp.c:		int err = -errno;
btio/btio.c:		int error = -errno;
btio/btio.c:		int error = -errno;
btio/btio.c:		int error = -errno;
network/common.c:		int err = errno;
network/common.c:		int err = errno;
network/common.c:		int err = errno;
serial/port.c:		int err = -errno;
serial/port.c:		int err = -errno;
time/server.c:		int err = errno;   (*)
tools/hcitool.c:		int err = errno;

This one is from a patch I sent (not yet applied), will fix.

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil