From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH] l2cap_chan_connect() shouldn't be inlined
Date: Mon, 6 Feb 2012 10:43:21 +0200 [thread overview]
Message-ID: <20120206084319.GB12455@aemeltch-MOBL1> (raw)
In-Reply-To: <1328469130.2062.77.camel@aeonflux>
Hi all,
On Sun, Feb 05, 2012 at 11:12:10AM -0800, Marcel Holtmann wrote:
> Hi Al,
>
> > For one thing, it's big. For another, the only caller is in a different
> > file anyway...
> >
> > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> >
> > diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h
> > index 68f5891..124f7cf 100644
> > --- a/include/net/bluetooth/l2cap.h
> > +++ b/include/net/bluetooth/l2cap.h
> > @@ -834,7 +834,7 @@ int l2cap_add_scid(struct l2cap_chan *chan, __u16 scid);
> > struct l2cap_chan *l2cap_chan_create(struct sock *sk);
> > void l2cap_chan_close(struct l2cap_chan *chan, int reason);
> > void l2cap_chan_destroy(struct l2cap_chan *chan);
> > -inline int l2cap_chan_connect(struct l2cap_chan *chan, __le16 psm, u16 cid,
> > +int l2cap_chan_connect(struct l2cap_chan *chan, __le16 psm, u16 cid,
> > bdaddr_t *dst);
>
> I have no idea on how that happened, but you are fully correct this is
> pointless.
>
> Acked-by: Marcel Holtmann <marcel@holtmann.org>
Similar patch has been already applied a month ago to our bluetooth tree
commit 79aa1a3322cfa65199a0d87eacd41bd1fbc33a1d
Author: Johan Hedberg <johan.hedberg@intel.com>
Date: Sun Jan 8 22:51:16 2012 +0200
Best regards
Andrei Emeltchenko
prev parent reply other threads:[~2012-02-06 8:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-05 6:21 [PATCH] l2cap_chan_connect() shouldn't be inlined Al Viro
2012-02-05 19:12 ` Marcel Holtmann
2012-02-06 8:43 ` Andrei Emeltchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120206084319.GB12455@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox