* [PATCH] Bluetooth: Correct CID endian notation
@ 2012-03-09 13:52 Andrei Emeltchenko
2012-03-15 18:51 ` Gustavo Padovan
0 siblings, 1 reply; 3+ messages in thread
From: Andrei Emeltchenko @ 2012-03-09 13:52 UTC (permalink / raw)
To: linux-bluetooth
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
L2CAP channel id is used in host format in internal L2CAP code.
Fix sparse warnings about wrong endian conversion.
Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
---
net/bluetooth/l2cap_core.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index 50579ee..428e0b0 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -871,7 +871,7 @@ static void l2cap_conn_start(struct l2cap_conn *conn)
/* Find socket with cid and source bdaddr.
* Returns closest match, locked.
*/
-static struct l2cap_chan *l2cap_global_chan_by_scid(int state, __le16 cid, bdaddr_t *src)
+static struct l2cap_chan *l2cap_global_chan_by_scid(int state, u16 cid, bdaddr_t *src)
{
struct l2cap_chan *c, *c1 = NULL;
@@ -4435,7 +4435,7 @@ drop:
return 0;
}
-static inline int l2cap_att_channel(struct l2cap_conn *conn, __le16 cid, struct sk_buff *skb)
+static inline int l2cap_att_channel(struct l2cap_conn *conn, u16 cid, struct sk_buff *skb)
{
struct l2cap_chan *chan;
--
1.7.9
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Bluetooth: Correct CID endian notation
2012-03-09 13:52 [PATCH] Bluetooth: Correct CID endian notation Andrei Emeltchenko
@ 2012-03-15 18:51 ` Gustavo Padovan
2012-03-15 18:54 ` Gustavo Padovan
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo Padovan @ 2012-03-15 18:51 UTC (permalink / raw)
To: Andrei Emeltchenko; +Cc: linux-bluetooth
Hi Andrei,
* Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com> [2012-03-09 15:52:56 +0200]:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> L2CAP channel id is used in host format in internal L2CAP code.
> Fix sparse warnings about wrong endian conversion.
>
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
> net/bluetooth/l2cap_core.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Acked-by: Gustavo Padovan <gustavo@padovan.org>
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: Correct CID endian notation
2012-03-15 18:51 ` Gustavo Padovan
@ 2012-03-15 18:54 ` Gustavo Padovan
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo Padovan @ 2012-03-15 18:54 UTC (permalink / raw)
To: Andrei Emeltchenko; +Cc: linux-bluetooth
* Gustavo Padovan <gustavo@padovan.org> [2012-03-15 15:51:24 -0300]:
> Hi Andrei,
>
> * Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com> [2012-03-09 15:52:56 +0200]:
>
> > From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> >
> > L2CAP channel id is used in host format in internal L2CAP code.
> > Fix sparse warnings about wrong endian conversion.
> >
> > Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> > ---
> > net/bluetooth/l2cap_core.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
>
> Acked-by: Gustavo Padovan <gustavo@padovan.org>
Humm, seems Johan already picked this one.
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-15 18:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-09 13:52 [PATCH] Bluetooth: Correct CID endian notation Andrei Emeltchenko
2012-03-15 18:51 ` Gustavo Padovan
2012-03-15 18:54 ` Gustavo Padovan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox