[RFC PATCH BlueZ] doc: Revert "Small API update"

[RFC PATCH BlueZ] doc: Revert "Small API update"

[Anderson Lizardo]

This reverts commit fd1ac97806d4531cb54523b3d694899afce281e7. It seems
the "entered" param is not used anymore.
---
 doc/agent-api.txt |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/doc/agent-api.txt b/doc/agent-api.txt
index 9ab2063..193a2d1 100644
--- a/doc/agent-api.txt
+++ b/doc/agent-api.txt
@@ -42,21 +42,15 @@ Methods		void Release()
 			Possible errors: org.bluez.Error.Rejected
 			                 org.bluez.Error.Canceled
 
-		void DisplayPasskey(object device, uint32 passkey, uint8 entered)
+		void DisplayPasskey(object device, uint32 passkey)
 
 			This method gets called when the service daemon
 			needs to display a passkey for an authentication.
 
-			The entered parameter indicates the number of already
-			typed keys on the remote side.
-
 			An empty reply should be returned. When the passkey
 			needs no longer to be displayed, the Cancel method
 			of the agent will be called.
 
-			During the pairing process this method might be
-			called multiple times to update the entered value.
-
 			Note that the passkey will always be a 6-digit number,
 			so the display should be zero-padded at the start if
 			the value contains less than 6 digits.
-- 
1.7.5.4

Re: [RFC PATCH BlueZ] doc: Revert "Small API update"

[Johan Hedberg]

Hi Lizardo,

On Mon, Mar 26, 2012, Anderson Lizardo wrote:
> This reverts commit fd1ac97806d4531cb54523b3d694899afce281e7. It seems
> the "entered" param is not used anymore.
> ---
>  doc/agent-api.txt |    8 +-------
>  1 files changed, 1 insertions(+), 7 deletions(-)

Why do you want to remove this? How else can we relay key press
notifications to the user? Like with your other patch the fact that some
code is not used doesn't necessarily mean that it should be removed but
that something needs to be added to make it useful.

Also, it seems we've forgotten this part from the mgmt API as there's no
event specified for it at the moment.

Johan

Re: [RFC PATCH BlueZ] doc: Revert "Small API update"

[Anderson Lizardo]

Hi Johan,

On Tue, Mar 27, 2012 at 7:59 AM, Johan Hedberg <johan.hedberg@gmail.com> wrote:
> Hi Lizardo,
>
> On Mon, Mar 26, 2012, Anderson Lizardo wrote:
>> This reverts commit fd1ac97806d4531cb54523b3d694899afce281e7. It seems
>> the "entered" param is not used anymore.
>> ---
>>  doc/agent-api.txt |    8 +-------
>>  1 files changed, 1 insertions(+), 7 deletions(-)
>
> Why do you want to remove this? How else can we relay key press
> notifications to the user? Like with your other patch the fact that some
> code is not used doesn't necessarily mean that it should be removed but
> that something needs to be added to make it useful.

That's the reason I sent as RFC. I needed input like this :) Usually
patches are more visible here than abstract questions. It also shows
specifically where the "dangling part" is.

Also note that these two places lacked some sort of TODO/FIXME
comment. I could simply ask, but just sending this RFC patch seemed
more effective.

> Also, it seems we've forgotten this part from the mgmt API as there's no
> event specified for it at the moment.

Will you take care of this for mgmtops? If so, I can just fix the
dev_class patch, which I think has the kernel side in place already.

Best Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil