From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: Andre Guedes <andre.guedes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC 3/3] Bluetooth: Use address type info from User-space
Date: Wed, 28 Mar 2012 17:26:03 +0300 [thread overview]
Message-ID: <20120328142601.GB31354@aemeltch-MOBL1> (raw)
In-Reply-To: <CACJA=fX9WSAqKZfLxp_iY2WiNoUXrGc=ch0DWdFXZvitOXPiZA@mail.gmail.com>
Hi Andre,
On Wed, Mar 28, 2012 at 11:05:47AM -0300, Andre Guedes wrote:
> >> -int l2cap_chan_connect(struct l2cap_chan *chan, __le16 psm, u16 cid, bdaddr_t *dst)
> >> +int l2cap_chan_connect(struct l2cap_chan *chan, __le16 psm, u16 cid,
> >> + bdaddr_t *dst, u8 dst_type)
> >> {
> >> struct sock *sk = chan->sk;
> >> bdaddr_t *src = &bt_sk(sk)->src;
> >> @@ -1141,8 +1142,8 @@ int l2cap_chan_connect(struct l2cap_chan *chan, __le16 psm, u16 cid, bdaddr_t *d
> >> __u8 auth_type;
> >> int err;
> >>
> >> - BT_DBG("%s -> %s psm 0x%2.2x", batostr(src), batostr(dst),
> >> - __le16_to_cpu(chan->psm));
> >> + BT_DBG("%s -> %s (type %u) psm 0x%2.2x", batostr(src), batostr(dst),
> >> + dst_type, __le16_to_cpu(chan->psm));
> >
> > If you change style for other functions you might change it here as well.
>
> Sorry, didn't follow you here.
In l2cap_chan_connect you seems align second line at "(". Maybe we need
then align the same for debug statement?
Best regards
Andrei Emeltchenko
next prev parent reply other threads:[~2012-03-28 14:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 23:59 [RFC 0/3] LE Connection Andre Guedes
2012-03-27 23:59 ` [RFC 1/3] Bluetooth: Add address type to struct sockaddr_l2 Andre Guedes
2012-03-27 23:59 ` [RFC 2/3] Bluetooth: Add dst_type parameter to hci_connect Andre Guedes
2012-03-28 8:48 ` Andrei Emeltchenko
2012-03-28 14:05 ` Andre Guedes
2012-03-29 9:12 ` Johan Hedberg
2012-03-29 17:13 ` Andre Guedes
2012-03-29 17:31 ` Marcel Holtmann
2012-03-29 17:56 ` Andre Guedes
2012-03-27 23:59 ` [RFC 3/3] Bluetooth: Use address type info from User-space Andre Guedes
2012-03-28 8:56 ` Andrei Emeltchenko
2012-03-28 14:05 ` Andre Guedes
2012-03-28 14:26 ` Andrei Emeltchenko [this message]
2012-03-28 17:15 ` Andre Guedes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120328142601.GB31354@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox