From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andre Guedes <andre.guedes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC 2/3] Bluetooth: Add dst_type parameter to hci_connect
Date: Thu, 29 Mar 2012 12:12:36 +0300 [thread overview]
Message-ID: <20120329091236.GA22600@x220> (raw)
In-Reply-To: <1332892776-12060-3-git-send-email-andre.guedes@openbossa.org>
Hi Andre,
On Tue, Mar 27, 2012, Andre Guedes wrote:
> + le->dst_type = (dst_type == MGMT_ADDR_LE_RANDOM) ?
> + ADDR_LE_DEV_RANDOM : ADDR_LE_DEV_PUBLIC;
You might want to make a simple helper function for the type conversion.
Also, I'm not so sure it's a good idea to directly reuse mgmt API
defines for the L2CAP socket interface. The values may in the end be the
same but probably there should be separate defines in l2cap.h.
Johan
next prev parent reply other threads:[~2012-03-29 9:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 23:59 [RFC 0/3] LE Connection Andre Guedes
2012-03-27 23:59 ` [RFC 1/3] Bluetooth: Add address type to struct sockaddr_l2 Andre Guedes
2012-03-27 23:59 ` [RFC 2/3] Bluetooth: Add dst_type parameter to hci_connect Andre Guedes
2012-03-28 8:48 ` Andrei Emeltchenko
2012-03-28 14:05 ` Andre Guedes
2012-03-29 9:12 ` Johan Hedberg [this message]
2012-03-29 17:13 ` Andre Guedes
2012-03-29 17:31 ` Marcel Holtmann
2012-03-29 17:56 ` Andre Guedes
2012-03-27 23:59 ` [RFC 3/3] Bluetooth: Use address type info from User-space Andre Guedes
2012-03-28 8:56 ` Andrei Emeltchenko
2012-03-28 14:05 ` Andre Guedes
2012-03-28 14:26 ` Andrei Emeltchenko
2012-03-28 17:15 ` Andre Guedes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120329091236.GA22600@x220 \
--to=johan.hedberg@gmail.com \
--cc=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox