From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: Claudio Takahasi <claudio.takahasi@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org,
Andre Guedes <andre.guedes@openbossa.org>
Subject: Re: [RFC BlueZ 4/4] l2test: Add option to inform the address type
Date: Thu, 5 Apr 2012 09:35:15 +0300 [thread overview]
Message-ID: <20120405063513.GA804@aemeltch-MOBL1> (raw)
In-Reply-To: <1333570571-29650-4-git-send-email-claudio.takahasi@openbossa.org>
Hi Claudio,
On Wed, Apr 04, 2012 at 05:16:11PM -0300, Claudio Takahasi wrote:
...
> + addr.l2_bdaddr_type = bdaddr_type;
> if (cid)
...
> @@ -1020,6 +1022,7 @@ static void info_request(char *svr)
> + addr.l2_bdaddr_type = bdaddr_type;
...
> @@ -1167,6 +1170,7 @@ static void do_pairing(char *svr)
> + addr.l2_bdaddr_type = bdaddr_type;
...
> + case 'V':
> + bdaddr_type = atoi(optarg);
Apparently there is no check that value is correct. I think that you can
use here lookup_table (see l2cap_modes and chan_policies).
Best regards
Andrei Emeltchenko
next prev parent reply other threads:[~2012-04-05 6:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 20:16 [RFC BlueZ 1/4] Add Bluetooth address type in sockaddr_l2 Claudio Takahasi
2012-04-04 20:16 ` [RFC BlueZ 2/4] btio: Add address type in bt_io_connect Claudio Takahasi
2012-04-05 10:28 ` Johan Hedberg
2012-04-05 22:38 ` [RFC BlueZ v1 2/7] " Claudio Takahasi
2012-04-04 20:16 ` [RFC BlueZ 3/4] Add address type for BLE bt_io_connect calls Claudio Takahasi
2012-04-05 22:38 ` [RFC BlueZ v1 3/7] " Claudio Takahasi
2012-04-04 20:16 ` [RFC BlueZ 4/4] l2test: Add option to inform the address type Claudio Takahasi
2012-04-05 6:35 ` Andrei Emeltchenko [this message]
2012-04-05 22:38 ` [RFC BlueZ v1 7/7] " Claudio Takahasi
2012-04-05 23:17 ` [RFC BlueZ 4/4] " Andre Guedes
2012-04-05 10:30 ` [RFC BlueZ 1/4] Add Bluetooth address type in sockaddr_l2 Johan Hedberg
2012-04-05 22:38 ` [RFC BlueZ v1 1/7] " Claudio Takahasi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120405063513.GA804@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=andre.guedes@openbossa.org \
--cc=claudio.takahasi@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox