From: Johan Hedberg <johan.hedberg@gmail.com>
To: Claudio Takahasi <claudio.takahasi@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC BlueZ 2/4] btio: Add address type in bt_io_connect
Date: Thu, 5 Apr 2012 13:28:05 +0300 [thread overview]
Message-ID: <20120405102805.GE32212@x220> (raw)
In-Reply-To: <1333570571-29650-2-git-send-email-claudio.takahasi@openbossa.org>
Hi Claudio,
On Wed, Apr 04, 2012, Claudio Takahasi wrote:
> @@ -714,6 +717,9 @@ static gboolean parse_set_opts(struct set_opts *opts, GError **err,
> case BT_IO_OPT_DEST_BDADDR:
> bacpy(&opts->dst, va_arg(args, const bdaddr_t *));
> break;
> + case BT_IO_OPT_DEST_TYPE:
> + opts->dst_type = va_arg(args, int);
> + break;
> case BT_IO_OPT_DEFER_TIMEOUT:
> opts->defer = va_arg(args, int);
> break;
I'd prefer that you also add a line to the "Set defaults" section of
this function to initialize opts->dst_type (I know the default is
implicitly 0 but it's good to have it there for clarity). Also, are you
planning to add BT_IO_* defines/enum for the types or what value is the
new BtIO API expecting to receive (this should probably be documented
and you do need to know the answer to the question before adding the
initialization line I requested).
Johan
next prev parent reply other threads:[~2012-04-05 10:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 20:16 [RFC BlueZ 1/4] Add Bluetooth address type in sockaddr_l2 Claudio Takahasi
2012-04-04 20:16 ` [RFC BlueZ 2/4] btio: Add address type in bt_io_connect Claudio Takahasi
2012-04-05 10:28 ` Johan Hedberg [this message]
2012-04-05 22:38 ` [RFC BlueZ v1 2/7] " Claudio Takahasi
2012-04-04 20:16 ` [RFC BlueZ 3/4] Add address type for BLE bt_io_connect calls Claudio Takahasi
2012-04-05 22:38 ` [RFC BlueZ v1 3/7] " Claudio Takahasi
2012-04-04 20:16 ` [RFC BlueZ 4/4] l2test: Add option to inform the address type Claudio Takahasi
2012-04-05 6:35 ` Andrei Emeltchenko
2012-04-05 22:38 ` [RFC BlueZ v1 7/7] " Claudio Takahasi
2012-04-05 23:17 ` [RFC BlueZ 4/4] " Andre Guedes
2012-04-05 10:30 ` [RFC BlueZ 1/4] Add Bluetooth address type in sockaddr_l2 Johan Hedberg
2012-04-05 22:38 ` [RFC BlueZ v1 1/7] " Claudio Takahasi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120405102805.GE32212@x220 \
--to=johan.hedberg@gmail.com \
--cc=claudio.takahasi@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox