From: Johan Hedberg <johan.hedberg@gmail.com>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] input: add error message when auth fails
Date: Mon, 23 Apr 2012 13:15:35 +0300 [thread overview]
Message-ID: <20120423101535.GA8903@x220> (raw)
In-Reply-To: <1334943375-23475-1-git-send-email-gustavo@padovan.org>
Hi Gustavo,
On Fri, Apr 20, 2012, Gustavo Padovan wrote:
> ---
> input/server.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/input/server.c b/input/server.c
> index cea08d1..ed09a73 100644
> --- a/input/server.c
> +++ b/input/server.c
> @@ -176,6 +176,8 @@ static void confirm_event_cb(GIOChannel *chan, gpointer user_data)
> if (ret == 0)
> return;
>
> + error("Authorization failed(%d): %s", -ret, strerror(-ret));
> +
> g_io_channel_unref(server->confirm);
> server->confirm = NULL;
Thanks, applied after making the message a bit more informative.
Remember that error() doesn't include any context info like DBG() does,
i.e. you wouldn't even know that the error message is from the input
plugin.
Johan
prev parent reply other threads:[~2012-04-23 10:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 17:36 [PATCH] input: add error message when auth fails Gustavo Padovan
2012-04-23 10:15 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423101535.GA8903@x220 \
--to=johan.hedberg@gmail.com \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox