* [PATCH] input: add error message when auth fails
@ 2012-04-20 17:36 Gustavo Padovan
2012-04-23 10:15 ` Johan Hedberg
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo Padovan @ 2012-04-20 17:36 UTC (permalink / raw)
To: linux-bluetooth
---
input/server.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/input/server.c b/input/server.c
index cea08d1..ed09a73 100644
--- a/input/server.c
+++ b/input/server.c
@@ -176,6 +176,8 @@ static void confirm_event_cb(GIOChannel *chan, gpointer user_data)
if (ret == 0)
return;
+ error("Authorization failed(%d): %s", -ret, strerror(-ret));
+
g_io_channel_unref(server->confirm);
server->confirm = NULL;
--
1.7.10
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] input: add error message when auth fails
2012-04-20 17:36 [PATCH] input: add error message when auth fails Gustavo Padovan
@ 2012-04-23 10:15 ` Johan Hedberg
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2012-04-23 10:15 UTC (permalink / raw)
To: Gustavo Padovan; +Cc: linux-bluetooth
Hi Gustavo,
On Fri, Apr 20, 2012, Gustavo Padovan wrote:
> ---
> input/server.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/input/server.c b/input/server.c
> index cea08d1..ed09a73 100644
> --- a/input/server.c
> +++ b/input/server.c
> @@ -176,6 +176,8 @@ static void confirm_event_cb(GIOChannel *chan, gpointer user_data)
> if (ret == 0)
> return;
>
> + error("Authorization failed(%d): %s", -ret, strerror(-ret));
> +
> g_io_channel_unref(server->confirm);
> server->confirm = NULL;
Thanks, applied after making the message a bit more informative.
Remember that error() doesn't include any context info like DBG() does,
i.e. you wouldn't even know that the error message is from the input
plugin.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-23 10:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-20 17:36 [PATCH] input: add error message when auth fails Gustavo Padovan
2012-04-23 10:15 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox