* [PATCH BlueZ] mgmtops: Fix endianness conversion
@ 2012-07-30 18:13 Anderson Lizardo
2012-07-30 18:15 ` [PATCH v2 BlueZ] monitor: " Anderson Lizardo
2012-07-31 13:18 ` [PATCH BlueZ] mgmtops: " Anderson Lizardo
0 siblings, 2 replies; 5+ messages in thread
From: Anderson Lizardo @ 2012-07-30 18:13 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Anderson Lizardo
Flags field has 32-bit size. Same issue was fixed for mgmtops in
1801a4d45d74c29cebacaab79a07e9961300be41.
---
monitor/control.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/monitor/control.c b/monitor/control.c
index 159ba9d..54b249d 100644
--- a/monitor/control.c
+++ b/monitor/control.c
@@ -210,7 +210,7 @@ static void mgmt_device_connected(uint16_t len, const void *buf)
return;
}
- flags = btohs(ev->flags);
+ flags = btohl(ev->flags);
ba2str(&ev->addr.bdaddr, str);
printf("@ Device Connected: %s (%d) flags 0x%4.4x\n",
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v2 BlueZ] monitor: Fix endianness conversion
2012-07-30 18:13 [PATCH BlueZ] mgmtops: Fix endianness conversion Anderson Lizardo
@ 2012-07-30 18:15 ` Anderson Lizardo
2012-07-31 13:21 ` [PATCH v3 " Anderson Lizardo
2012-07-31 13:18 ` [PATCH BlueZ] mgmtops: " Anderson Lizardo
1 sibling, 1 reply; 5+ messages in thread
From: Anderson Lizardo @ 2012-07-30 18:15 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Anderson Lizardo
Flags field has 32-bit size. Same issue was fixed for mgmtops in
1801a4d45d74c29cebacaab79a07e9961300be41.
---
Fix subject: mgmtops -> monitor
monitor/control.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/monitor/control.c b/monitor/control.c
index 159ba9d..54b249d 100644
--- a/monitor/control.c
+++ b/monitor/control.c
@@ -210,7 +210,7 @@ static void mgmt_device_connected(uint16_t len, const void *buf)
return;
}
- flags = btohs(ev->flags);
+ flags = btohl(ev->flags);
ba2str(&ev->addr.bdaddr, str);
printf("@ Device Connected: %s (%d) flags 0x%4.4x\n",
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v3 BlueZ] monitor: Fix endianness conversion
2012-07-30 18:15 ` [PATCH v2 BlueZ] monitor: " Anderson Lizardo
@ 2012-07-31 13:21 ` Anderson Lizardo
2012-08-13 10:24 ` Johan Hedberg
0 siblings, 1 reply; 5+ messages in thread
From: Anderson Lizardo @ 2012-07-31 13:21 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Anderson Lizardo
Flags field has 32-bit size. Same issue was fixed for mgmtops in
1801a4d45d74c29cebacaab79a07e9961300be41.
---
v2 -> v3: Fix another occurrence of same bug.
monitor/control.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/monitor/control.c b/monitor/control.c
index 159ba9d..3f5b990 100644
--- a/monitor/control.c
+++ b/monitor/control.c
@@ -210,7 +210,7 @@ static void mgmt_device_connected(uint16_t len, const void *buf)
return;
}
- flags = btohs(ev->flags);
+ flags = btohl(ev->flags);
ba2str(&ev->addr.bdaddr, str);
printf("@ Device Connected: %s (%d) flags 0x%4.4x\n",
@@ -357,7 +357,7 @@ static void mgmt_device_found(uint16_t len, const void *buf)
return;
}
- flags = btohs(ev->flags);
+ flags = btohl(ev->flags);
ba2str(&ev->addr.bdaddr, str);
printf("@ Device Found: %s (%d) rssi %d flags 0x%4.4x\n",
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v3 BlueZ] monitor: Fix endianness conversion
2012-07-31 13:21 ` [PATCH v3 " Anderson Lizardo
@ 2012-08-13 10:24 ` Johan Hedberg
0 siblings, 0 replies; 5+ messages in thread
From: Johan Hedberg @ 2012-08-13 10:24 UTC (permalink / raw)
To: Anderson Lizardo; +Cc: linux-bluetooth
Hi Lizardo,
On Tue, Jul 31, 2012, Anderson Lizardo wrote:
> Flags field has 32-bit size. Same issue was fixed for mgmtops in
> 1801a4d45d74c29cebacaab79a07e9961300be41.
> ---
>
> v2 -> v3: Fix another occurrence of same bug.
>
> monitor/control.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied. Thanks.
Johan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH BlueZ] mgmtops: Fix endianness conversion
2012-07-30 18:13 [PATCH BlueZ] mgmtops: Fix endianness conversion Anderson Lizardo
2012-07-30 18:15 ` [PATCH v2 BlueZ] monitor: " Anderson Lizardo
@ 2012-07-31 13:18 ` Anderson Lizardo
1 sibling, 0 replies; 5+ messages in thread
From: Anderson Lizardo @ 2012-07-31 13:18 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Anderson Lizardo
Hi,
On Mon, Jul 30, 2012 at 2:13 PM, Anderson Lizardo
<anderson.lizardo@openbossa.org> wrote:
> Flags field has 32-bit size. Same issue was fixed for mgmtops in
> 1801a4d45d74c29cebacaab79a07e9961300be41.
> ---
I make a mistake on the subject prefix, please apply v3 instead.
Regards,
--
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-08-13 10:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-30 18:13 [PATCH BlueZ] mgmtops: Fix endianness conversion Anderson Lizardo
2012-07-30 18:15 ` [PATCH v2 BlueZ] monitor: " Anderson Lizardo
2012-07-31 13:21 ` [PATCH v3 " Anderson Lizardo
2012-08-13 10:24 ` Johan Hedberg
2012-07-31 13:18 ` [PATCH BlueZ] mgmtops: " Anderson Lizardo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox