From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andrzej Kaczmarek <andrzej.kaczmarek@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2] Cycling Speed and Cadence profile (CSCP) API
Date: Fri, 28 Sep 2012 16:26:13 +0300 [thread overview]
Message-ID: <20120928132613.GB5075@x220> (raw)
In-Reply-To: <1348585647-25458-2-git-send-email-andrzej.kaczmarek@tieto.com>
Hi Andrzej,
On Tue, Sep 25, 2012, Andrzej Kaczmarek wrote:
> + Possible values: "Other", "Top of shoe", "In shoe",
> + "Hip", "Front Wheel", "Left Crank",
> + "Right Crank", "Left Pedal",
> + "Right Pedal", "Front Hub",
> + "Rear Dropout", "Chainstay",
> + "Rear Wheel", "Rear Hub"
As I've pointed out in a couple of other (unrelated) patch reviews keep
string dict values lower-case. Also leave the spaces out. So you'll end
up getting stuff like "top-of-shoe", "in-shoe", "hip", etc.
Johan
prev parent reply other threads:[~2012-09-28 13:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 15:07 [RFC v2] Cycling Speed and Cadence profile (CSCP) API Andrzej Kaczmarek
2012-09-25 15:07 ` [PATCH " Andrzej Kaczmarek
2012-09-28 13:26 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120928132613.GB5075@x220 \
--to=johan.hedberg@gmail.com \
--cc=andrzej.kaczmarek@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox