* [PATCH v2] Bluetooth: Remove OOB data if device was discovered in band
@ 2012-11-20 10:38 Szymon Janc
2012-11-20 12:24 ` Johan Hedberg
2012-11-20 18:04 ` Gustavo Padovan
0 siblings, 2 replies; 3+ messages in thread
From: Szymon Janc @ 2012-11-20 10:38 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Szymon Janc
OOB authentication mechanism should be used only if pairing process
has been activated by previous OOB information exchange (Core Spec
4.0 , vol. 1, Part A, 5.1.4.3). Stored OOB data for specific device
should be removed if that device was discovered in band later on.
Signed-off-by: Szymon Janc <szymon.janc@tieto.com>
---
V2:
Move OOB data removal to hci_inquiry_cache_update to cover all inquiry
events (ext/rssi) in one place.
net/bluetooth/hci_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index e3a49db..81f4bac 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -434,6 +434,8 @@ bool hci_inquiry_cache_update(struct hci_dev *hdev, struct inquiry_data *data,
BT_DBG("cache %p, %pMR", cache, &data->bdaddr);
+ hci_remove_remote_oob_data(hdev, &data->bdaddr);
+
if (ssp)
*ssp = data->ssp_mode;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] Bluetooth: Remove OOB data if device was discovered in band
2012-11-20 10:38 [PATCH v2] Bluetooth: Remove OOB data if device was discovered in band Szymon Janc
@ 2012-11-20 12:24 ` Johan Hedberg
2012-11-20 18:04 ` Gustavo Padovan
1 sibling, 0 replies; 3+ messages in thread
From: Johan Hedberg @ 2012-11-20 12:24 UTC (permalink / raw)
To: Szymon Janc; +Cc: linux-bluetooth
Hi Szymon,
On Tue, Nov 20, 2012, Szymon Janc wrote:
> OOB authentication mechanism should be used only if pairing process
> has been activated by previous OOB information exchange (Core Spec
> 4.0 , vol. 1, Part A, 5.1.4.3). Stored OOB data for specific device
> should be removed if that device was discovered in band later on.
>
> Signed-off-by: Szymon Janc <szymon.janc@tieto.com>
> ---
> V2:
> Move OOB data removal to hci_inquiry_cache_update to cover all inquiry
> events (ext/rssi) in one place.
>
> net/bluetooth/hci_core.c | 2 ++
> 1 file changed, 2 insertions(+)
Acked-by: Johan Hedberg <johan.hedberg@intel.com>
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] Bluetooth: Remove OOB data if device was discovered in band
2012-11-20 10:38 [PATCH v2] Bluetooth: Remove OOB data if device was discovered in band Szymon Janc
2012-11-20 12:24 ` Johan Hedberg
@ 2012-11-20 18:04 ` Gustavo Padovan
1 sibling, 0 replies; 3+ messages in thread
From: Gustavo Padovan @ 2012-11-20 18:04 UTC (permalink / raw)
To: Szymon Janc; +Cc: linux-bluetooth
Hi Szymon,
* Szymon Janc <szymon.janc@tieto.com> [2012-11-20 11:38:54 +0100]:
> OOB authentication mechanism should be used only if pairing process
> has been activated by previous OOB information exchange (Core Spec
> 4.0 , vol. 1, Part A, 5.1.4.3). Stored OOB data for specific device
> should be removed if that device was discovered in band later on.
>
> Signed-off-by: Szymon Janc <szymon.janc@tieto.com>
> ---
> V2:
> Move OOB data removal to hci_inquiry_cache_update to cover all inquiry
> events (ext/rssi) in one place.
>
> net/bluetooth/hci_core.c | 2 ++
> 1 file changed, 2 insertions(+)
patch has been applied to bluetooth-next. Thanks.
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-20 18:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-20 10:38 [PATCH v2] Bluetooth: Remove OOB data if device was discovered in band Szymon Janc
2012-11-20 12:24 ` Johan Hedberg
2012-11-20 18:04 ` Gustavo Padovan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox