From: Johan Hedberg <johan.hedberg@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Fix bogus __le16_to_cpu call
Date: Tue, 19 Mar 2013 09:59:21 +0200 [thread overview]
Message-ID: <20130319075921.GA16093@x220> (raw)
In-Reply-To: <1363678634-15338-1-git-send-email-johan.hedberg@gmail.com>
Hi,
On Tue, Mar 19, 2013, Johan Hedberg wrote:
> The type member of struct hci_rp_read_page_scan_type is u8 so no
> byte order conversion is necessary for it. This patch removes a bogus
> call to __le16_to_cpu on it.
>
> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
> ---
> net/bluetooth/hci_event.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> index 8a1f511..1385807 100644
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -641,7 +641,7 @@ static void hci_cc_read_page_scan_type(struct hci_dev *hdev,
> BT_DBG("%s status 0x%2.2x", hdev->name, rp->status);
>
> if (test_bit(HCI_INIT, &hdev->flags) && !rp->status)
> - hdev->page_scan_type = __le16_to_cpu(rp->type);
> + hdev->page_scan_type = rp->type;
> }
>
> static void hci_cc_write_page_scan_type(struct hci_dev *hdev,
Just ignore this one. I should have checked for new emails on
linux-bluetooth before creating it since this was already taken care of.
Johan
prev parent reply other threads:[~2013-03-19 7:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 7:37 [PATCH] Bluetooth: Fix bogus __le16_to_cpu call Johan Hedberg
2013-03-19 7:59 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130319075921.GA16093@x220 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox