From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andre Guedes <andre.guedes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] Bluetooth: Fix HCI request for Inquiry command
Date: Fri, 22 Mar 2013 13:09:09 +0200 [thread overview]
Message-ID: <20130322110909.GA11186@x220.ger.corp.intel.com> (raw)
In-Reply-To: <1363788708-28355-2-git-send-email-andre.guedes@openbossa.org>
Hi Andre,
On Wed, Mar 20, 2013, Andre Guedes wrote:
> @@ -1079,6 +1077,8 @@ static void hci_cs_inquiry(struct hci_dev *hdev, __u8 status)
> {
> BT_DBG("%s status 0x%2.2x", hdev->name, status);
>
> + hci_req_cmd_complete(hdev, HCI_OP_INQUIRY, status);
> +
> if (status) {
> hci_conn_check_pending(hdev);
> hci_dev_lock(hdev);
What about the hci_req_cmd_status call in the hci_cmd_status_evt
function? hci_req_cmd_status could call hci_req_cmd_complete in which
case you'd get two calls to that function for the same event.
I have a feeling that if you really want to consider all commands as
completed based on command status events we should just skip the whole
hci_req_cmd_status/complete distinction and remove the
hci_req_cmd_status function completely (always calling cmd_complete).
Johan
next prev parent reply other threads:[~2013-03-22 11:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 14:11 [PATCH 0/2] Fix Inquiry command support in HCI request framework Andre Guedes
2013-03-20 14:11 ` [PATCH 1/2] Bluetooth: Fix HCI request for Inquiry command Andre Guedes
2013-03-22 11:09 ` Johan Hedberg [this message]
2013-03-26 12:59 ` Andre Guedes
2013-03-20 14:11 ` [PATCH 2/2] Bluetooth: Fix hci_inquiry Andre Guedes
2013-03-22 11:20 ` [PATCH 0/2] Fix Inquiry command support in HCI request framework Johan Hedberg
2013-03-26 12:59 ` Andre Guedes
2013-03-26 13:17 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130322110909.GA11186@x220.ger.corp.intel.com \
--to=johan.hedberg@gmail.com \
--cc=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox