From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andre Guedes <andre.guedes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 0/2] Fix Inquiry command support in HCI request framework
Date: Fri, 22 Mar 2013 13:20:31 +0200 [thread overview]
Message-ID: <20130322112031.GA11536@x220.ger.corp.intel.com> (raw)
In-Reply-To: <1363788708-28355-1-git-send-email-andre.guedes@openbossa.org>
Hi Andre,
On Wed, Mar 20, 2013, Andre Guedes wrote:
> HCI Inquiry command causes the controller to enter in inquiry mode. A
> successful Command Status Event for this command means the the
> controller is running the inquiry procedure therefore the HCI Inquiry
> command has completed. The Inquiry Complete Event, on the other hand,
> means the inquiry _procedure_ (not the HCI command) has completed.
It would be good if you could show exact quotes from the core
specification instead of making stuff up. Here's an exact quote from the
core spec (page 706) regarding events generated by the Inquiry command:
"No Command Complete event will be sent by the BR/EDR Controller to
indicate that this command has been completed. Instead, the Inquiry
Complete event will indicate that this command has been completed."
That's quite the opposite of what you're claiming, with no references to
the procedure completion but only the command completion. This makes me
feel like you're trying to persuade us to a particular technical outcome
that suits your needs with the help of misleading/inaccurate
information.
It might well be in our best interest to keep processing our
request/command queue based on command status events (essentially
treating the commands as completed) but let's at least be honest about
what the exact wording in the core specification is.
Johan
next prev parent reply other threads:[~2013-03-22 11:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 14:11 [PATCH 0/2] Fix Inquiry command support in HCI request framework Andre Guedes
2013-03-20 14:11 ` [PATCH 1/2] Bluetooth: Fix HCI request for Inquiry command Andre Guedes
2013-03-22 11:09 ` Johan Hedberg
2013-03-26 12:59 ` Andre Guedes
2013-03-20 14:11 ` [PATCH 2/2] Bluetooth: Fix hci_inquiry Andre Guedes
2013-03-22 11:20 ` Johan Hedberg [this message]
2013-03-26 12:59 ` [PATCH 0/2] Fix Inquiry command support in HCI request framework Andre Guedes
2013-03-26 13:17 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130322112031.GA11536@x220.ger.corp.intel.com \
--to=johan.hedberg@gmail.com \
--cc=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox