* [PATCH] Bluetooth: Avoid dumplicate conn dev register
@ 2013-04-09 6:43 Feng Hong
2013-04-12 2:43 ` [PATCH] Bluetooth: Avoid duplicate " Feng Hong
0 siblings, 1 reply; 3+ messages in thread
From: Feng Hong @ 2013-04-09 6:43 UTC (permalink / raw)
To: marcel, gustavo, johan.hedberg; +Cc: linux-bluetooth, Feng Hong
Once hit dumplicate connection device register:
[ 651.865509] WARNING: at lib/kobject.c:198
kobject_add_internal+0x1f4/0x264()
[ 651.872894] kobject_add_internal failed for hci0:1 with -EEXIST,
don't try to register things with the same name in the same directory.
[ 651.885650] Modules linked in: runcase_sysfs(O) sd8xxx(O) mlan(O)
bt8xxx(O) cidatattydev(O) gs_diag(O) diag(O) gs_modem(O) ccinetdev(O)
cci_datastub(O) citty(O) msocketk(O) smsmdtv seh(O) cploaddev(O) blcr(O)
blcr_imports(O) geu(O) galcore(O)
[ 651.910125] [<c011991c>] (unwind_backtrace+0x0/0x11c) from
[<c0134d3c>] (warn_slowpath_common+0x4c/0x64)
[ 651.920013] [<c0134d3c>] (warn_slowpath_common+0x4c/0x64) from
[<c0134dd4>] (warn_slowpath_fmt+0x2c/0x3c)
[ 651.930053] [<c0134dd4>] (warn_slowpath_fmt+0x2c/0x3c) from
[<c02d91e0>] (kobject_add_internal+0x1f4/0x264)
[ 651.940246] [<c02d91e0>] (kobject_add_internal+0x1f4/0x264) from
[<c02d95f0>] (kobject_add+0x68/0x8c)
[ 651.949890] [<c02d95f0>] (kobject_add+0x68/0x8c) from [<c03323c8>]
(device_add+0x104/0x5b8)
[ 651.958831] [<c03323c8>] (device_add+0x104/0x5b8) from [<c0547484>]
(hci_conn_add_sysfs+0x4c/0x80)
[ 651.968109] [<c0547484>] (hci_conn_add_sysfs+0x4c/0x80) from
[<c053996c>] (hci_event_packet+0x530/0x6428)
[ 651.978149] [<c053996c>] (hci_event_packet+0x530/0x6428) from
[<c05342a8>] (hci_rx_work+0xd0/0x390)
[ 651.987640] [<c05342a8>] (hci_rx_work+0xd0/0x390) from [<c014ce24>]
(process_one_work+0x280/0x488)
[ 651.996978] [<c014ce24>] (process_one_work+0x280/0x488) from
[<c014d240>] (worker_thread+0x214/0x3b4)
[ 652.006652] [<c014d240>] (worker_thread+0x214/0x3b4) from
[<c01511b4>] (kthread+0x80/0x8c)
[ 652.015228] [<c01511b4>] (kthread+0x80/0x8c) from [<c0113ed8>]
(kernel_thread_exit+0x0/0x8)
[ 652.023925] ---[ end trace 7d6ac73956376f0a ]---
[ 652.035034] Bluetooth: Failed to register connection device
dev->device_private struct will be freed in device_add, later on anyone
go through father/child list will meet panic like this:
[ 668.902984] Unable to handle kernel NULL pointer dereference at
virtual address 00000004
[ 668.903015] pgd = c0104000
[ 668.903015] [00000004] *pgd=00000000
[ 668.903045] Internal error: Oops: 805 [#1] PREEMPT SMP ARM
[ 668.903106] Modules linked in: runcase_sysfs(O) sd8xxx(O) mlan(O)
bt8xxx(O) cidatattydev(O) gs_diag(O) diag(O) gs_modem(O) ccinetdev(O)
cci_datastub(O) citty(O) msocketk(O) smsmdtv seh(O
) cploaddev(O) blcr(O) blcr_imports(O) geu(O) galcore(O)
[ 668.903228] CPU: 1 Tainted: G W O (3.4.5+ #1)
[ 668.903259] PC is at klist_release+0x30/0xe0
[ 668.903289] LR is at warn_slowpath_null+0x18/0x1c
[ 668.908081] [<c059d028>] (klist_release+0x30/0xe0) from [<c059d10c>]
(klist_dec_and_del+0x34/0x44)
[ 668.908142] [<c059d10c>] (klist_dec_and_del+0x34/0x44) from
[<c059d148>] (klist_next+0x2c/0xd8)
[ 668.908172] [<c059d148>] (klist_next+0x2c/0xd8) from [<c03317f4>]
(device_for_each_child+0x44/0x70)
[ 668.908233] [<c03317f4>] (device_for_each_child+0x44/0x70) from
[<c033a5ec>] (__device_suspend+0x20/0x340)
[ 668.908294] [<c033a5ec>] (__device_suspend+0x20/0x340) from
[<c033b1e8>] (dpm_suspend+0xa8/0x210)
[ 668.908325] [<c033b1e8>] (dpm_suspend+0xa8/0x210) from [<c0168770>]
(suspend_devices_and_enter+0xd4/0x390)
[ 668.908386] [<c0168770>] (suspend_devices_and_enter+0xd4/0x390) from
[<c0168b7c>] (pm_suspend+0x150/0x234)
[ 668.908416] [<c0168b7c>] (pm_suspend+0x150/0x234) from [<c0168cf4>]
(try_to_suspend+0x64/0xa8)
[ 668.908477] [<c0168cf4>] (try_to_suspend+0x64/0xa8) from [<c014ce24>]
(process_one_work+0x280/0x488)
[ 668.908508] [<c014ce24>] (process_one_work+0x280/0x488) from
[<c014d240>] (worker_thread+0x214/0x3b4)
[ 668.908569] [<c014d240>] (worker_thread+0x214/0x3b4) from
[<c01511b4>] (kthread+0x80/0x8c)
[ 668.908630] [<c01511b4>] (kthread+0x80/0x8c) from [<c0113ed8>]
(kernel_thread_exit+0x0/0x8)
This patch is trying to add protection in this case.
Change-Id: I028d9bda88139bdaba475a5cebbf27acbcaf3a05
Signed-off-by: Feng Hong <hongfeng@marvell.com>
---
net/bluetooth/hci_sysfs.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/net/bluetooth/hci_sysfs.c b/net/bluetooth/hci_sysfs.c
index 23b4e24..5c23d13 100644
--- a/net/bluetooth/hci_sysfs.c
+++ b/net/bluetooth/hci_sysfs.c
@@ -116,6 +116,11 @@ void hci_conn_add_sysfs(struct hci_conn *conn)
{
struct hci_dev *hdev = conn->hdev;
+ if (device_is_registered(&conn->dev)) {
+ BT_ERR("Duplicate register connection device");
+ return;
+ }
+
BT_DBG("conn %p", conn);
dev_set_name(&conn->dev, "%s:%d", hdev->name, conn->handle);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] Bluetooth: Avoid duplicate conn dev register
2013-04-09 6:43 [PATCH] Bluetooth: Avoid dumplicate conn dev register Feng Hong
@ 2013-04-12 2:43 ` Feng Hong
2013-04-18 2:55 ` Gustavo Padovan
0 siblings, 1 reply; 3+ messages in thread
From: Feng Hong @ 2013-04-12 2:43 UTC (permalink / raw)
To: marcel@holtmann.org, gustavo@padovan.org, johan.hedberg@gmail.com
Cc: linux-bluetooth@vger.kernel.org
SGVsbG8sIE1hcmNlbCBIb2x0bWFubiwgR3VzdGF2byBQYWRvdmFuLCBKb2hhbiBIZWRiZXJnLA0K
DQpXaGF0J3MgeW91ciBpZGVhIHdoeSBiZWxvdyB3YXJuaW5nIHdpbGwgaGFwcGVuID8NClsgIDY1
MS44NjU1MDldIFdBUk5JTkc6IGF0IGxpYi9rb2JqZWN0LmM6MTk4IGtvYmplY3RfYWRkX2ludGVy
bmFsKzB4MWY0LzB4MjY0KCkNClsgIDY1MS44NzI4OTRdIGtvYmplY3RfYWRkX2ludGVybmFsIGZh
aWxlZCBmb3IgaGNpMDoxIHdpdGggLUVFWElTVCwgZG9uJ3QgdHJ5IHRvIHJlZ2lzdGVyIHRoaW5n
cyB3aXRoIHRoZSBzYW1lIG5hbWUgaW4gdGhlIHNhbWUgZGlyZWN0b3J5Lg0KWyAgNjUxLjkxMDEy
NV0gWzxjMDExOTkxYz5dICh1bndpbmRfYmFja3RyYWNlKzB4MC8weDExYykgZnJvbSBbPGMwMTM0
ZDNjPl0gKHdhcm5fc2xvd3BhdGhfY29tbW9uKzB4NGMvMHg2NCkNClsgIDY1MS45MjAwMTNdIFs8
YzAxMzRkM2M+XSAod2Fybl9zbG93cGF0aF9jb21tb24rMHg0Yy8weDY0KSBmcm9tIFs8YzAxMzRk
ZDQ+XSAod2Fybl9zbG93cGF0aF9mbXQrMHgyYy8weDNjKQ0KWyAgNjUxLjkzMDA1M10gWzxjMDEz
NGRkND5dICh3YXJuX3Nsb3dwYXRoX2ZtdCsweDJjLzB4M2MpIGZyb20gWzxjMDJkOTFlMD5dIChr
b2JqZWN0X2FkZF9pbnRlcm5hbCsweDFmNC8weDI2NCkNClsgIDY1MS45NDAyNDZdIFs8YzAyZDkx
ZTA+XSAoa29iamVjdF9hZGRfaW50ZXJuYWwrMHgxZjQvMHgyNjQpIGZyb20gWzxjMDJkOTVmMD5d
IChrb2JqZWN0X2FkZCsweDY4LzB4OGMpDQpbICA2NTEuOTQ5ODkwXSBbPGMwMmQ5NWYwPl0gKGtv
YmplY3RfYWRkKzB4NjgvMHg4YykgZnJvbSBbPGMwMzMyM2M4Pl0gKGRldmljZV9hZGQrMHgxMDQv
MHg1YjgpDQpbICA2NTEuOTU4ODMxXSBbPGMwMzMyM2M4Pl0gKGRldmljZV9hZGQrMHgxMDQvMHg1
YjgpIGZyb20gWzxjMDU0NzQ4ND5dIChoY2lfY29ubl9hZGRfc3lzZnMrMHg0Yy8weDgwKQ0KWyAg
NjUxLjk2ODEwOV0gWzxjMDU0NzQ4ND5dIChoY2lfY29ubl9hZGRfc3lzZnMrMHg0Yy8weDgwKSBm
cm9tIFs8YzA1Mzk5NmM+XSAoaGNpX2V2ZW50X3BhY2tldCsweDUzMC8weDY0MjgpDQpbICA2NTEu
OTc4MTQ5XSBbPGMwNTM5OTZjPl0gKGhjaV9ldmVudF9wYWNrZXQrMHg1MzAvMHg2NDI4KSBmcm9t
IFs8YzA1MzQyYTg+XSAoaGNpX3J4X3dvcmsrMHhkMC8weDM5MCkNClsgIDY1MS45ODc2NDBdIFs8
YzA1MzQyYTg+XSAoaGNpX3J4X3dvcmsrMHhkMC8weDM5MCkgZnJvbSBbPGMwMTRjZTI0Pl0gKHBy
b2Nlc3Nfb25lX3dvcmsrMHgyODAvMHg0ODgpDQpbICA2NTEuOTk2OTc4XSBbPGMwMTRjZTI0Pl0g
KHByb2Nlc3Nfb25lX3dvcmsrMHgyODAvMHg0ODgpIGZyb20gWzxjMDE0ZDI0MD5dICh3b3JrZXJf
dGhyZWFkKzB4MjE0LzB4M2I0KQ0KWyAgNjUyLjAwNjY1Ml0gWzxjMDE0ZDI0MD5dICh3b3JrZXJf
dGhyZWFkKzB4MjE0LzB4M2I0KSBmcm9tIFs8YzAxNTExYjQ+XSAoa3RocmVhZCsweDgwLzB4OGMp
DQpbICA2NTIuMDE1MjI4XSBbPGMwMTUxMWI0Pl0gKGt0aHJlYWQrMHg4MC8weDhjKSBmcm9tIFs8
YzAxMTNlZDg+XSAoa2VybmVsX3RocmVhZF9leGl0KzB4MC8weDgpDQpbICA2NTIuMDIzOTI1XSAt
LS1bIGVuZCB0cmFjZSA3ZDZhYzczOTU2Mzc2ZjBhIF0tLS0NClsgIDY1Mi4wMzUwMzRdIEJsdWV0
b290aDogRmFpbGVkIHRvIHJlZ2lzdGVyIGNvbm5lY3Rpb24gZGV2aWNlDQoNCkFuZCBpZiBhYm92
ZSByZWFsbHkgaGFwcGVuLCB0aGUgcGF0Y2ggYmVsb3cgY2FuIGF2b2lkIHN5c3RlbSBmcm9tIHBh
bmljLCB3aGF0J3MgeW91ciBjb21tZW50cyBvbiB0aGlzIHByb3RlY3Rpb24gPyANCldhaXRpbmcg
Zm9yIHlvdXIgcmVwbHkgb24gdGhpcywgdGhhbmsgeW91IHZlcnkgbXVjaCAhDQoNCi0tDQpCZXN0
IFJlZ2FyZHMsDQpGZW5nIEhvbmcNCkFwcGxpY2F0aW9uIFByb2Nlc3NvciBTb2Z0d2FyZSBFbmdu
aWVlciANCk1hcnZlbGwgVGVjaG5vbG9neSAoU2hhbmdoYWkpIEx0ZA0KDQoNCi0tLS0tT3JpZ2lu
YWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBGZW5nIEhvbmcgW21haWx0bzpob25nZmVuZ0BtYXJ2ZWxs
LmNvbV0gDQpTZW50OiAyMDEzxOo01MI5yNUgMTQ6NDQNClRvOiBtYXJjZWxAaG9sdG1hbm4ub3Jn
OyBndXN0YXZvQHBhZG92YW4ub3JnOyBqb2hhbi5oZWRiZXJnQGdtYWlsLmNvbQ0KQ2M6IGxpbnV4
LWJsdWV0b290aEB2Z2VyLmtlcm5lbC5vcmc7IEZlbmcgSG9uZw0KU3ViamVjdDogW1BBVENIXSBC
bHVldG9vdGg6IEF2b2lkIGR1bXBsaWNhdGUgY29ubiBkZXYgcmVnaXN0ZXINCg0KT25jZSBoaXQg
ZHVtcGxpY2F0ZSBjb25uZWN0aW9uIGRldmljZSByZWdpc3RlcjoNCg0KWyAgNjUxLjg2NTUwOV0g
V0FSTklORzogYXQgbGliL2tvYmplY3QuYzoxOTgNCmtvYmplY3RfYWRkX2ludGVybmFsKzB4MWY0
LzB4MjY0KCkNClsgIDY1MS44NzI4OTRdIGtvYmplY3RfYWRkX2ludGVybmFsIGZhaWxlZCBmb3Ig
aGNpMDoxIHdpdGggLUVFWElTVCwNCmRvbid0IHRyeSB0byByZWdpc3RlciB0aGluZ3Mgd2l0aCB0
aGUgc2FtZSBuYW1lIGluIHRoZSBzYW1lIGRpcmVjdG9yeS4NClsgIDY1MS44ODU2NTBdIE1vZHVs
ZXMgbGlua2VkIGluOiBydW5jYXNlX3N5c2ZzKE8pIHNkOHh4eChPKSBtbGFuKE8pDQpidDh4eHgo
TykgY2lkYXRhdHR5ZGV2KE8pIGdzX2RpYWcoTykgZGlhZyhPKSBnc19tb2RlbShPKSBjY2luZXRk
ZXYoTykNCmNjaV9kYXRhc3R1YihPKSBjaXR0eShPKSBtc29ja2V0ayhPKSBzbXNtZHR2IHNlaChP
KSBjcGxvYWRkZXYoTykgYmxjcihPKQ0KYmxjcl9pbXBvcnRzKE8pIGdldShPKSBnYWxjb3JlKE8p
DQpbICA2NTEuOTEwMTI1XSBbPGMwMTE5OTFjPl0gKHVud2luZF9iYWNrdHJhY2UrMHgwLzB4MTFj
KSBmcm9tDQpbPGMwMTM0ZDNjPl0gKHdhcm5fc2xvd3BhdGhfY29tbW9uKzB4NGMvMHg2NCkNClsg
IDY1MS45MjAwMTNdIFs8YzAxMzRkM2M+XSAod2Fybl9zbG93cGF0aF9jb21tb24rMHg0Yy8weDY0
KSBmcm9tDQpbPGMwMTM0ZGQ0Pl0gKHdhcm5fc2xvd3BhdGhfZm10KzB4MmMvMHgzYykNClsgIDY1
MS45MzAwNTNdIFs8YzAxMzRkZDQ+XSAod2Fybl9zbG93cGF0aF9mbXQrMHgyYy8weDNjKSBmcm9t
DQpbPGMwMmQ5MWUwPl0gKGtvYmplY3RfYWRkX2ludGVybmFsKzB4MWY0LzB4MjY0KQ0KWyAgNjUx
Ljk0MDI0Nl0gWzxjMDJkOTFlMD5dIChrb2JqZWN0X2FkZF9pbnRlcm5hbCsweDFmNC8weDI2NCkg
ZnJvbQ0KWzxjMDJkOTVmMD5dIChrb2JqZWN0X2FkZCsweDY4LzB4OGMpDQpbICA2NTEuOTQ5ODkw
XSBbPGMwMmQ5NWYwPl0gKGtvYmplY3RfYWRkKzB4NjgvMHg4YykgZnJvbSBbPGMwMzMyM2M4Pl0N
CihkZXZpY2VfYWRkKzB4MTA0LzB4NWI4KQ0KWyAgNjUxLjk1ODgzMV0gWzxjMDMzMjNjOD5dIChk
ZXZpY2VfYWRkKzB4MTA0LzB4NWI4KSBmcm9tIFs8YzA1NDc0ODQ+XQ0KKGhjaV9jb25uX2FkZF9z
eXNmcysweDRjLzB4ODApDQpbICA2NTEuOTY4MTA5XSBbPGMwNTQ3NDg0Pl0gKGhjaV9jb25uX2Fk
ZF9zeXNmcysweDRjLzB4ODApIGZyb20NCls8YzA1Mzk5NmM+XSAoaGNpX2V2ZW50X3BhY2tldCsw
eDUzMC8weDY0MjgpDQpbICA2NTEuOTc4MTQ5XSBbPGMwNTM5OTZjPl0gKGhjaV9ldmVudF9wYWNr
ZXQrMHg1MzAvMHg2NDI4KSBmcm9tDQpbPGMwNTM0MmE4Pl0gKGhjaV9yeF93b3JrKzB4ZDAvMHgz
OTApDQpbICA2NTEuOTg3NjQwXSBbPGMwNTM0MmE4Pl0gKGhjaV9yeF93b3JrKzB4ZDAvMHgzOTAp
IGZyb20gWzxjMDE0Y2UyND5dDQoocHJvY2Vzc19vbmVfd29yaysweDI4MC8weDQ4OCkNClsgIDY1
MS45OTY5NzhdIFs8YzAxNGNlMjQ+XSAocHJvY2Vzc19vbmVfd29yaysweDI4MC8weDQ4OCkgZnJv
bQ0KWzxjMDE0ZDI0MD5dICh3b3JrZXJfdGhyZWFkKzB4MjE0LzB4M2I0KQ0KWyAgNjUyLjAwNjY1
Ml0gWzxjMDE0ZDI0MD5dICh3b3JrZXJfdGhyZWFkKzB4MjE0LzB4M2I0KSBmcm9tDQpbPGMwMTUx
MWI0Pl0gKGt0aHJlYWQrMHg4MC8weDhjKQ0KWyAgNjUyLjAxNTIyOF0gWzxjMDE1MTFiND5dIChr
dGhyZWFkKzB4ODAvMHg4YykgZnJvbSBbPGMwMTEzZWQ4Pl0NCihrZXJuZWxfdGhyZWFkX2V4aXQr
MHgwLzB4OCkNClsgIDY1Mi4wMjM5MjVdIC0tLVsgZW5kIHRyYWNlIDdkNmFjNzM5NTYzNzZmMGEg
XS0tLQ0KWyAgNjUyLjAzNTAzNF0gQmx1ZXRvb3RoOiBGYWlsZWQgdG8gcmVnaXN0ZXIgY29ubmVj
dGlvbiBkZXZpY2UNCg0KIGRldi0+ZGV2aWNlX3ByaXZhdGUgc3RydWN0IHdpbGwgYmUgZnJlZWQg
aW4gZGV2aWNlX2FkZCwgbGF0ZXIgb24gYW55b25lDQpnbyB0aHJvdWdoIGZhdGhlci9jaGlsZCBs
aXN0IHdpbGwgbWVldCBwYW5pYyBsaWtlIHRoaXM6DQoNClsgIDY2OC45MDI5ODRdIFVuYWJsZSB0
byBoYW5kbGUga2VybmVsIE5VTEwgcG9pbnRlciBkZXJlZmVyZW5jZSBhdA0KdmlydHVhbCBhZGRy
ZXNzIDAwMDAwMDA0DQpbICA2NjguOTAzMDE1XSBwZ2QgPSBjMDEwNDAwMA0KWyAgNjY4LjkwMzAx
NV0gWzAwMDAwMDA0XSAqcGdkPTAwMDAwMDAwDQpbICA2NjguOTAzMDQ1XSBJbnRlcm5hbCBlcnJv
cjogT29wczogODA1IFsjMV0gUFJFRU1QVCBTTVAgQVJNDQpbICA2NjguOTAzMTA2XSBNb2R1bGVz
IGxpbmtlZCBpbjogcnVuY2FzZV9zeXNmcyhPKSBzZDh4eHgoTykgbWxhbihPKQ0KYnQ4eHh4KE8p
IGNpZGF0YXR0eWRldihPKSBnc19kaWFnKE8pIGRpYWcoTykgZ3NfbW9kZW0oTykgY2NpbmV0ZGV2
KE8pDQpjY2lfZGF0YXN0dWIoTykgY2l0dHkoTykgbXNvY2tldGsoTykgc21zbWR0diBzZWgoTw0K
KSBjcGxvYWRkZXYoTykgYmxjcihPKSBibGNyX2ltcG9ydHMoTykgZ2V1KE8pIGdhbGNvcmUoTykN
ClsgIDY2OC45MDMyMjhdIENQVTogMSAgICBUYWludGVkOiBHICAgICAgICBXICBPICAoMy40LjUr
ICMxKQ0KWyAgNjY4LjkwMzI1OV0gUEMgaXMgYXQga2xpc3RfcmVsZWFzZSsweDMwLzB4ZTANClsg
IDY2OC45MDMyODldIExSIGlzIGF0IHdhcm5fc2xvd3BhdGhfbnVsbCsweDE4LzB4MWMNClsgIDY2
OC45MDgwODFdIFs8YzA1OWQwMjg+XSAoa2xpc3RfcmVsZWFzZSsweDMwLzB4ZTApIGZyb20gWzxj
MDU5ZDEwYz5dDQooa2xpc3RfZGVjX2FuZF9kZWwrMHgzNC8weDQ0KQ0KWyAgNjY4LjkwODE0Ml0g
WzxjMDU5ZDEwYz5dIChrbGlzdF9kZWNfYW5kX2RlbCsweDM0LzB4NDQpIGZyb20NCls8YzA1OWQx
NDg+XSAoa2xpc3RfbmV4dCsweDJjLzB4ZDgpDQpbICA2NjguOTA4MTcyXSBbPGMwNTlkMTQ4Pl0g
KGtsaXN0X25leHQrMHgyYy8weGQ4KSBmcm9tIFs8YzAzMzE3ZjQ+XQ0KKGRldmljZV9mb3JfZWFj
aF9jaGlsZCsweDQ0LzB4NzApDQpbICA2NjguOTA4MjMzXSBbPGMwMzMxN2Y0Pl0gKGRldmljZV9m
b3JfZWFjaF9jaGlsZCsweDQ0LzB4NzApIGZyb20NCls8YzAzM2E1ZWM+XSAoX19kZXZpY2Vfc3Vz
cGVuZCsweDIwLzB4MzQwKQ0KWyAgNjY4LjkwODI5NF0gWzxjMDMzYTVlYz5dIChfX2RldmljZV9z
dXNwZW5kKzB4MjAvMHgzNDApIGZyb20NCls8YzAzM2IxZTg+XSAoZHBtX3N1c3BlbmQrMHhhOC8w
eDIxMCkNClsgIDY2OC45MDgzMjVdIFs8YzAzM2IxZTg+XSAoZHBtX3N1c3BlbmQrMHhhOC8weDIx
MCkgZnJvbSBbPGMwMTY4NzcwPl0NCihzdXNwZW5kX2RldmljZXNfYW5kX2VudGVyKzB4ZDQvMHgz
OTApDQpbICA2NjguOTA4Mzg2XSBbPGMwMTY4NzcwPl0gKHN1c3BlbmRfZGV2aWNlc19hbmRfZW50
ZXIrMHhkNC8weDM5MCkgZnJvbQ0KWzxjMDE2OGI3Yz5dIChwbV9zdXNwZW5kKzB4MTUwLzB4MjM0
KQ0KWyAgNjY4LjkwODQxNl0gWzxjMDE2OGI3Yz5dIChwbV9zdXNwZW5kKzB4MTUwLzB4MjM0KSBm
cm9tIFs8YzAxNjhjZjQ+XQ0KKHRyeV90b19zdXNwZW5kKzB4NjQvMHhhOCkNClsgIDY2OC45MDg0
NzddIFs8YzAxNjhjZjQ+XSAodHJ5X3RvX3N1c3BlbmQrMHg2NC8weGE4KSBmcm9tIFs8YzAxNGNl
MjQ+XQ0KKHByb2Nlc3Nfb25lX3dvcmsrMHgyODAvMHg0ODgpDQpbICA2NjguOTA4NTA4XSBbPGMw
MTRjZTI0Pl0gKHByb2Nlc3Nfb25lX3dvcmsrMHgyODAvMHg0ODgpIGZyb20NCls8YzAxNGQyNDA+
XSAod29ya2VyX3RocmVhZCsweDIxNC8weDNiNCkNClsgIDY2OC45MDg1NjldIFs8YzAxNGQyNDA+
XSAod29ya2VyX3RocmVhZCsweDIxNC8weDNiNCkgZnJvbQ0KWzxjMDE1MTFiND5dIChrdGhyZWFk
KzB4ODAvMHg4YykNClsgIDY2OC45MDg2MzBdIFs8YzAxNTExYjQ+XSAoa3RocmVhZCsweDgwLzB4
OGMpIGZyb20gWzxjMDExM2VkOD5dDQooa2VybmVsX3RocmVhZF9leGl0KzB4MC8weDgpDQoNClRo
aXMgcGF0Y2ggaXMgdHJ5aW5nIHRvIGFkZCBwcm90ZWN0aW9uIGluIHRoaXMgY2FzZS4NCg0KQ2hh
bmdlLUlkOiBJMDI4ZDliZGE4ODEzOWJkYWJhNDc1YTVjZWJiZjI3YWNiY2FmM2EwNQ0KU2lnbmVk
LW9mZi1ieTogRmVuZyBIb25nIDxob25nZmVuZ0BtYXJ2ZWxsLmNvbT4NCi0tLQ0KIG5ldC9ibHVl
dG9vdGgvaGNpX3N5c2ZzLmMgfCAgICA1ICsrKysrDQogMSBmaWxlcyBjaGFuZ2VkLCA1IGluc2Vy
dGlvbnMoKyksIDAgZGVsZXRpb25zKC0pDQoNCmRpZmYgLS1naXQgYS9uZXQvYmx1ZXRvb3RoL2hj
aV9zeXNmcy5jIGIvbmV0L2JsdWV0b290aC9oY2lfc3lzZnMuYw0KaW5kZXggMjNiNGUyNC4uNWMy
M2QxMyAxMDA2NDQNCi0tLSBhL25ldC9ibHVldG9vdGgvaGNpX3N5c2ZzLmMNCisrKyBiL25ldC9i
bHVldG9vdGgvaGNpX3N5c2ZzLmMNCkBAIC0xMTYsNiArMTE2LDExIEBAIHZvaWQgaGNpX2Nvbm5f
YWRkX3N5c2ZzKHN0cnVjdCBoY2lfY29ubiAqY29ubikNCiB7DQogCXN0cnVjdCBoY2lfZGV2ICpo
ZGV2ID0gY29ubi0+aGRldjsNCiANCisJaWYgKGRldmljZV9pc19yZWdpc3RlcmVkKCZjb25uLT5k
ZXYpKSB7DQorCQlCVF9FUlIoIkR1cGxpY2F0ZSByZWdpc3RlciBjb25uZWN0aW9uIGRldmljZSIp
Ow0KKwkJcmV0dXJuOw0KKwl9DQorDQogCUJUX0RCRygiY29ubiAlcCIsIGNvbm4pOw0KIA0KIAlk
ZXZfc2V0X25hbWUoJmNvbm4tPmRldiwgIiVzOiVkIiwgaGRldi0+bmFtZSwgY29ubi0+aGFuZGxl
KTsNCi0tIA0KMS43LjAuNA0KDQo=
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: Avoid duplicate conn dev register
2013-04-12 2:43 ` [PATCH] Bluetooth: Avoid duplicate " Feng Hong
@ 2013-04-18 2:55 ` Gustavo Padovan
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo Padovan @ 2013-04-18 2:55 UTC (permalink / raw)
To: Feng Hong
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
linux-bluetooth@vger.kernel.org
Hi Feng,
* Feng Hong <hongfeng@marvell.com> [2013-04-11 19:43:48 -0700]:
> Hello, Marcel Holtmann, Gustavo Padovan, Johan Hedberg,
>
> What's your idea why below warning will happen ?
> [ 651.865509] WARNING: at lib/kobject.c:198 kobject_add_internal+0x1f4/0x264()
> [ 651.872894] kobject_add_internal failed for hci0:1 with -EEXIST, don't try to register things with the same name in the same directory.
> [ 651.910125] [<c011991c>] (unwind_backtrace+0x0/0x11c) from [<c0134d3c>] (warn_slowpath_common+0x4c/0x64)
> [ 651.920013] [<c0134d3c>] (warn_slowpath_common+0x4c/0x64) from [<c0134dd4>] (warn_slowpath_fmt+0x2c/0x3c)
> [ 651.930053] [<c0134dd4>] (warn_slowpath_fmt+0x2c/0x3c) from [<c02d91e0>] (kobject_add_internal+0x1f4/0x264)
> [ 651.940246] [<c02d91e0>] (kobject_add_internal+0x1f4/0x264) from [<c02d95f0>] (kobject_add+0x68/0x8c)
> [ 651.949890] [<c02d95f0>] (kobject_add+0x68/0x8c) from [<c03323c8>] (device_add+0x104/0x5b8)
> [ 651.958831] [<c03323c8>] (device_add+0x104/0x5b8) from [<c0547484>] (hci_conn_add_sysfs+0x4c/0x80)
> [ 651.968109] [<c0547484>] (hci_conn_add_sysfs+0x4c/0x80) from [<c053996c>] (hci_event_packet+0x530/0x6428)
> [ 651.978149] [<c053996c>] (hci_event_packet+0x530/0x6428) from [<c05342a8>] (hci_rx_work+0xd0/0x390)
> [ 651.987640] [<c05342a8>] (hci_rx_work+0xd0/0x390) from [<c014ce24>] (process_one_work+0x280/0x488)
> [ 651.996978] [<c014ce24>] (process_one_work+0x280/0x488) from [<c014d240>] (worker_thread+0x214/0x3b4)
> [ 652.006652] [<c014d240>] (worker_thread+0x214/0x3b4) from [<c01511b4>] (kthread+0x80/0x8c)
> [ 652.015228] [<c01511b4>] (kthread+0x80/0x8c) from [<c0113ed8>] (kernel_thread_exit+0x0/0x8)
> [ 652.023925] ---[ end trace 7d6ac73956376f0a ]---
> [ 652.035034] Bluetooth: Failed to register connection device
>
> And if above really happen, the patch below can avoid system from panic, what's your comments on this protection ?
I think that fc225c3f5 and other commits we recently added to bluetooth-next
may help you with this. Could give bluetooth-next a try please and see if this
is gone?
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-18 2:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-09 6:43 [PATCH] Bluetooth: Avoid dumplicate conn dev register Feng Hong
2013-04-12 2:43 ` [PATCH] Bluetooth: Avoid duplicate " Feng Hong
2013-04-18 2:55 ` Gustavo Padovan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox