From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC 04/16] android: Start Android Bluetooth daemon
Date: Mon, 30 Sep 2013 10:07:25 +0300 [thread overview]
Message-ID: <20130930070723.GA10262@aemeltch-MOBL1> (raw)
In-Reply-To: <9A70E0AA-C658-4B1D-8040-DD483CCD6047@holtmann.org>
Hi Marcel,
On Sun, Sep 29, 2013 at 03:28:44PM +0200, Marcel Holtmann wrote:
> Hi Andrei,
>
> > Start Android Bluetooth daemon from HAL init(). Make sure
> > that daemon is in "running" state.
> > ---
> > android/hal_bluetooth.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++-
> > 1 file changed, 53 insertions(+), 1 deletion(-)
> >
> > diff --git a/android/hal_bluetooth.c b/android/hal_bluetooth.c
> > index 5298618..036091e 100644
> > --- a/android/hal_bluetooth.c
> > +++ b/android/hal_bluetooth.c
> > @@ -23,11 +23,16 @@
> > #include <hardware/bluetooth.h>
> > #include <hardware/bt_sock.h>
> >
> > +#include <cutils/sockets.h>
> > +#include <cutils/properties.h>
> > +
> > #define LOG_TAG "BlueZ"
> > #include <cutils/log.h>
> >
> > #include "hal.h"
> >
> > +#define ANDROID_BLUEZ "bluezd"
> > +
>
> the name changes to either "btd" or "bluetoothd". We need to pick one, but it is not suppose to be "bluezd".
this is the name of the service as it named in init.rc, so if bluetoothd
is the name of the daemon executable then I name service as btd.
Maybe I change ANDROID_BLUEZ to ANDROID_BLUEZ_SVC ?
>
> > bt_callbacks_t *bt_hal_cbacks = NULL;
>
> This needs to be public?
Yes, they would be called from callback thread and, possibly, from here.
Best regards
Andrei Emeltchenko
next prev parent reply other threads:[~2013-09-30 7:07 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 14:12 [RFC 00/16] Basic code for Android BlueZ Andrei Emeltchenko
2013-09-27 14:12 ` [RFC 01/16] android: Add Adapter Bluetooth HAL template Andrei Emeltchenko
2013-09-27 14:12 ` [RFC 02/16] android: Add Socket " Andrei Emeltchenko
2013-09-27 14:12 ` [RFC 03/16] android: Enable Socket interface Andrei Emeltchenko
2013-09-27 16:04 ` Anderson Lizardo
2013-09-27 14:12 ` [RFC 04/16] android: Start Android Bluetooth daemon Andrei Emeltchenko
2013-09-29 13:28 ` Marcel Holtmann
2013-09-30 7:07 ` Andrei Emeltchenko [this message]
2013-09-27 14:12 ` [RFC 05/16] android: Add Android Makefile for mgmt library Andrei Emeltchenko
2013-09-29 13:34 ` Marcel Holtmann
2013-09-27 14:12 ` [RFC 06/16] android: Add basic mgmt initialization sequence Andrei Emeltchenko
2013-09-27 14:12 ` [RFC 07/16] android: Create HAL API header skeleton Andrei Emeltchenko
2013-09-27 14:12 ` [RFC 08/16] android: Add Android HAL callback task Andrei Emeltchenko
2013-09-29 13:22 ` Marcel Holtmann
2013-09-27 14:12 ` [RFC 09/16] android: Add adapter and device struct for BlueZ daemon Andrei Emeltchenko
2013-09-27 17:07 ` Anderson Lizardo
2013-09-29 13:38 ` Marcel Holtmann
2013-09-30 7:28 ` Andrei Emeltchenko
2013-09-27 14:12 ` [RFC 10/16] android: Add Android Makefile for libbluetooth Andrei Emeltchenko
2013-09-27 18:01 ` Anderson Lizardo
2013-09-30 7:32 ` Andrei Emeltchenko
2013-09-30 12:14 ` Szymon Janc
2013-09-27 14:12 ` [RFC 11/16] android: sdp: Reuse BlueZ SDP server in Android Andrei Emeltchenko
2013-09-29 13:31 ` Marcel Holtmann
2013-09-30 7:45 ` Szymon Janc
2013-09-30 7:47 ` Andrei Emeltchenko
2013-09-27 14:12 ` [RFC 12/16] android: Add cap to bind to port < 1024 Andrei Emeltchenko
2013-09-27 17:17 ` Anderson Lizardo
2013-09-27 17:21 ` Anderson Lizardo
2013-09-29 13:40 ` Marcel Holtmann
2013-09-30 7:36 ` Szymon Janc
2013-09-30 7:51 ` Andrei Emeltchenko
2013-09-27 14:12 ` [RFC 13/16] android: Implement read_info_complete callback Andrei Emeltchenko
2013-09-27 14:12 ` [RFC 14/16] android: Handle mgmt changed events Andrei Emeltchenko
2013-09-27 17:59 ` Anderson Lizardo
2013-09-27 14:12 ` [RFC 15/16] android: Implement basic HAL server Andrei Emeltchenko
2013-09-27 17:50 ` Anderson Lizardo
2013-09-30 8:25 ` Andrei Emeltchenko
2013-09-30 8:33 ` Marcel Holtmann
2013-09-30 10:26 ` Andrei Emeltchenko
2013-09-29 14:59 ` Johan Hedberg
2013-09-30 8:42 ` Andrei Emeltchenko
2013-09-27 14:12 ` [RFC 16/16] android: Add HAL message helpers Andrei Emeltchenko
2013-09-29 15:00 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130930070723.GA10262@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox