From: Szymon Janc <szymon.janc@tieto.com>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: Anderson Lizardo <anderson.lizardo@openbossa.org>,
BlueZ development <linux-bluetooth@vger.kernel.org>
Subject: Re: [RFC 10/16] android: Add Android Makefile for libbluetooth
Date: Mon, 30 Sep 2013 14:14:09 +0200 [thread overview]
Message-ID: <6873848.d8uRT0mZyA@uw000953> (raw)
In-Reply-To: <20130930073222.GC10262@aemeltch-MOBL1>
Hi,
> > On Fri, Sep 27, 2013 at 10:12 AM, Andrei Emeltchenko
> > <Andrei.Emeltchenko.news@gmail.com> wrote:
> > > +# to suppress the "pointer of type 'void *' used in arithmetic" warning
> > > +LOCAL_CFLAGS += -Wno-pointer-arith
> > > +
> > > +# to suppress the "missing initializer near initialization" warning
> > > +LOCAL_CFLAGS += -Wno-missing-field-initializers
> > > +
> > > +# to suppress the "may be used uninitialized in this function" warning
> > > +LOCAL_CFLAGS += -Wno-maybe-uninitialized
> >
> > I wonder why you are suppressing all those warnings. Do you plan to
> > re-enable them once the implementation is more complete?
>
> I think most warnings are the same as in standard BlueZ build. At some
> point those issue must be resolved IMO.
There seems to be a bug in sdp_set_profile_descs() error path, for some reason
gcc 4.6 on my box doesn't generate warning, yet android one does.
Will send a patch for that in a moment.
--
Szymon Janc
next prev parent reply other threads:[~2013-09-30 12:14 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 14:12 [RFC 00/16] Basic code for Android BlueZ Andrei Emeltchenko
2013-09-27 14:12 ` [RFC 01/16] android: Add Adapter Bluetooth HAL template Andrei Emeltchenko
2013-09-27 14:12 ` [RFC 02/16] android: Add Socket " Andrei Emeltchenko
2013-09-27 14:12 ` [RFC 03/16] android: Enable Socket interface Andrei Emeltchenko
2013-09-27 16:04 ` Anderson Lizardo
2013-09-27 14:12 ` [RFC 04/16] android: Start Android Bluetooth daemon Andrei Emeltchenko
2013-09-29 13:28 ` Marcel Holtmann
2013-09-30 7:07 ` Andrei Emeltchenko
2013-09-27 14:12 ` [RFC 05/16] android: Add Android Makefile for mgmt library Andrei Emeltchenko
2013-09-29 13:34 ` Marcel Holtmann
2013-09-27 14:12 ` [RFC 06/16] android: Add basic mgmt initialization sequence Andrei Emeltchenko
2013-09-27 14:12 ` [RFC 07/16] android: Create HAL API header skeleton Andrei Emeltchenko
2013-09-27 14:12 ` [RFC 08/16] android: Add Android HAL callback task Andrei Emeltchenko
2013-09-29 13:22 ` Marcel Holtmann
2013-09-27 14:12 ` [RFC 09/16] android: Add adapter and device struct for BlueZ daemon Andrei Emeltchenko
2013-09-27 17:07 ` Anderson Lizardo
2013-09-29 13:38 ` Marcel Holtmann
2013-09-30 7:28 ` Andrei Emeltchenko
2013-09-27 14:12 ` [RFC 10/16] android: Add Android Makefile for libbluetooth Andrei Emeltchenko
2013-09-27 18:01 ` Anderson Lizardo
2013-09-30 7:32 ` Andrei Emeltchenko
2013-09-30 12:14 ` Szymon Janc [this message]
2013-09-27 14:12 ` [RFC 11/16] android: sdp: Reuse BlueZ SDP server in Android Andrei Emeltchenko
2013-09-29 13:31 ` Marcel Holtmann
2013-09-30 7:45 ` Szymon Janc
2013-09-30 7:47 ` Andrei Emeltchenko
2013-09-27 14:12 ` [RFC 12/16] android: Add cap to bind to port < 1024 Andrei Emeltchenko
2013-09-27 17:17 ` Anderson Lizardo
2013-09-27 17:21 ` Anderson Lizardo
2013-09-29 13:40 ` Marcel Holtmann
2013-09-30 7:36 ` Szymon Janc
2013-09-30 7:51 ` Andrei Emeltchenko
2013-09-27 14:12 ` [RFC 13/16] android: Implement read_info_complete callback Andrei Emeltchenko
2013-09-27 14:12 ` [RFC 14/16] android: Handle mgmt changed events Andrei Emeltchenko
2013-09-27 17:59 ` Anderson Lizardo
2013-09-27 14:12 ` [RFC 15/16] android: Implement basic HAL server Andrei Emeltchenko
2013-09-27 17:50 ` Anderson Lizardo
2013-09-30 8:25 ` Andrei Emeltchenko
2013-09-30 8:33 ` Marcel Holtmann
2013-09-30 10:26 ` Andrei Emeltchenko
2013-09-29 14:59 ` Johan Hedberg
2013-09-30 8:42 ` Andrei Emeltchenko
2013-09-27 14:12 ` [RFC 16/16] android: Add HAL message helpers Andrei Emeltchenko
2013-09-29 15:00 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6873848.d8uRT0mZyA@uw000953 \
--to=szymon.janc@tieto.com \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=anderson.lizardo@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox